This repository was archived by the owner on Jul 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Adds tagged logging support and Logger::Formatter support #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added formatter to logger
Wow, I can commit via web interface on iPad from a train!
Add more rubies to Travis-CI config
fixes chunking for subclasses of GELF::Notifier
thx for the hint, @edmundoa :) fixes graylog-labs#13
Use default facility if progname is blank
This adds some basic API information to the README file, which didn't have any documentation about the API before. Some parts are copied from the wiki.
Add basic API usage information to README
|
Thanks for contributing to this project! To continue merging this PR, we need you to sign our Individual Contributor Assignment Agreement as described in https://www.graylog.org/contributing-to-graylog/ @meltingice Would you mind cleaning up those commits a little bit and rebase to current master? There are some unintended changes in this PR, like the unresolved conflicts in |
|
Seems like this is partly a duplicate of #35 now. Also, besides history cleanup, would you mind creating separate PRs for formatter support and tagged logging? |
|
@milgner I would like to close this PR - CLA is still beding and this is kind of outdated and might need some love. How would you decide? |
|
As if the missing CLA i'll close this PR now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on @mitnal's PR, which adds tagged logging support, and also adds support for logger formatters.