Add support for converting bcp47 script subtags into whatlang::Script #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCP 47 contains the RFC for standardized language tags and defines the language subtag registry at IANA.
This PR adds support for converting those subtags into
whatlang::Scriptand back again.I've added another case to
ParseErroras it is already a mixed bag kind of error enum and doing so will probably make it easier to enable deeper integration with the rest of the crates features (i.e. serde orFromStr).Note: For consistency I've implemented the
DisplayforParseErroragainst clippy recommendations.