nsh updates #5
Open
nsh updates #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And it feels really natural... ;-)
|
I haven't had time to review this yet, sorry! This coming week is also nodeConf, so between JSConf China, jetlag, and upcoming conferences I'm a little behind on time. I'll try to at least look over this before next weekend. |
|
Don't worry, I'm with exams and as I told you, I'm thinking about moving towards bashful + shelljs, so this two guys would need some love previously to be usable here :-) |
|
👍 |
Added coreutils to dependencies
It's better to do the symlink manually later, so also gives the option to use a different shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be working on updates and improvements of nsh on this pull-request. The first one start using REPL instead of plain readline and move the shell related functions to an independent module. Next ones will be enabling Javascript scripting while still allowing commands instantiation, and usage of shell.js (very powerful library, although seems are having some problems and needs some fixing...), and I hope later continue making it (ba)sh compatible.