Skip to content

Conversation

arjan-bal
Copy link
Contributor

Original PR: #8528
Related issue: #8517

RELEASE NOTES:

  • server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.

@arjan-bal arjan-bal added this to the 1.72 Release milestone Sep 4, 2025
…ow control (grpc#8528)

Fixes: grpc#8517

This change allows `t.closeStream()` to be executed even if the stream
state is `done`. This is required to allow streams to be cancelled to
timed out. See issue for detailed root cause.

RELEASE NOTES:
* server: Fix bug preventing streams from being cancelled or timed out
when blocked on flow control.
@arjan-bal arjan-bal force-pushed the cherry-pick-8528-v1.72.x branch from 61b6471 to 7373479 Compare September 4, 2025 07:02
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.54%. Comparing base (56abce1) to head (7d3960a).
⚠️ Report is 1 commits behind head on v1.72.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.72.x    #8552      +/-   ##
===========================================
- Coverage    82.04%   81.54%   -0.50%     
===========================================
  Files          412      412              
  Lines        40396    40396              
===========================================
- Hits         33141    32940     -201     
- Misses        5887     6080     +193     
- Partials      1368     1376       +8     
Files with missing lines Coverage Δ
internal/transport/http2_server.go 91.09% <100.00%> (-0.10%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal merged commit c4cabaa into grpc:v1.72.x Sep 4, 2025
20 of 23 checks passed
@arjan-bal arjan-bal deleted the cherry-pick-8528-v1.72.x branch September 4, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants