Skip to content

Conversation

arjan-bal
Copy link
Contributor

Original PR: #8528
Related issue: #8517

RELEASE NOTES:

  • server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.

…ow control (grpc#8528)

Fixes: grpc#8517

This change allows `t.closeStream()` to be executed even if the stream
state is `done`. This is required to allow streams to be cancelled to
timed out. See issue for detailed root cause.

RELEASE NOTES:
* server: Fix bug preventing streams from being cancelled or timed out
when blocked on flow control.
@arjan-bal arjan-bal added this to the 1.73 Release milestone Sep 4, 2025
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.85%. Comparing base (bd2d1b0) to head (5ba3d7e).
⚠️ Report is 1 commits behind head on v1.73.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.73.x    #8553      +/-   ##
===========================================
- Coverage    82.19%   81.85%   -0.35%     
===========================================
  Files          419      419              
  Lines        42021    42021              
===========================================
- Hits         34538    34395     -143     
- Misses        6012     6168     +156     
+ Partials      1471     1458      -13     
Files with missing lines Coverage Δ
internal/transport/http2_server.go 90.54% <100.00%> (-0.28%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal merged commit e3732dc into grpc:v1.73.x Sep 4, 2025
13 of 14 checks passed
@arjan-bal arjan-bal deleted the cherry-pick-8528-v1.73.x branch September 4, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants