Start moving PendingAuthListener away from mocking ServerCall. #12223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusazis
commented
Jul 16, 2025
|
|
||
| @Mock ServerCallHandler<Object, Object> next; | ||
| @Mock ServerCall<Object, Object> call; | ||
| @Mock ServerCall.Listener<Object> delegate; | ||
| @Captor ArgumentCaptor<Status> statusCaptor; | ||
|
|
||
| private final Metadata headers = new Metadata(); | ||
| private final PendingAuthListener<Object, Object> listener = new PendingAuthListener<>(); |
There was a problem hiding this comment.
I'm not sure if we can stop mocking ServerCall for the remaining untouched tests; I don't know how else we could enforce that the current methods are called in that order, specially the cancellation.
There was a problem hiding this comment.
You assert the order of ClientCall.Listener callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to use a real in-process service to reduce the mocking of ServerCall in preparation to run the tests in the internal Google infrastructure.