Skip to content

binder: Improve error descriptions for ServiceConnection callbacks #12263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 26, 2025
Merged

binder: Improve error descriptions for ServiceConnection callbacks #12263

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf40f5e
Better error messages
jdcormie Aug 7, 2025
7128816
java-format
jdcormie Aug 7, 2025
5cb985e
tweak
jdcormie Aug 7, 2025
8ab90f8
add force-stopped to the reasons
jdcormie Aug 7, 2025
84aa60c
extra space
jdcormie Aug 8, 2025
bb35b24
changed my mind again
jdcormie Aug 14, 2025
cbca4df
Merge branch 'grpc:master' into binding-died-message
jdcormie Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,19 +356,32 @@ public void onServiceConnected(ComponentName className, IBinder binder) {
@Override
@MainThread
public void onServiceDisconnected(ComponentName name) {
unbindInternal(Status.UNAVAILABLE.withDescription("onServiceDisconnected: " + name));
unbindInternal(
Status.UNAVAILABLE.withDescription(
"Server process crashed, exited or was killed (onServiceDisconnected): " + name));
}

@Override
@MainThread
public void onNullBinding(ComponentName name) {
unbindInternal(Status.UNIMPLEMENTED.withDescription("onNullBinding: " + name));
unbindInternal(
Status.UNIMPLEMENTED.withDescription(
"Remote Service returned null from onBind() for "
+ bindIntent
+ " (onNullBinding): "
+ name));
}

@Override
@MainThread
public void onBindingDied(ComponentName name) {
unbindInternal(Status.UNAVAILABLE.withDescription("onBindingDied: " + name));
unbindInternal(
Status.UNAVAILABLE.withDescription(
"Remote Service component "
+ name.getClassName()
+ " was disabled, or its package "
+ name.getPackageName()
+ " was disabled, force-stopped, replaced or uninstalled (onBindingDied)."));
}

@VisibleForTesting
Expand Down