-
Notifications
You must be signed in to change notification settings - Fork 677
Health list endpoint #2957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health list endpoint #2957
Conversation
If you run |
Thank you for the guidance! Running
My node version is Does this PR depend on unit tests to be "approvable"? I can add the test code and someone else can try to run them? |
I think the most likely issue you are seeing is that the git submodules that the setup script expects to be able to use are absent. You can correct that by running |
Thank you!, second approach worked (even tho 29 tests fail). I will work on the tests shortly. |
bb60aee
to
3b900f7
Compare
3b900f7
to
2fb705e
Compare
Hey @murgatroid99 can you help me understand why Windows Tests job is failing? doesn't seem to be related to my changes I believe. |
Ignore the Windows test job. It's broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this.
Way to go my friend! Thanks for the help! |
This has been released in version 2.1.0. |
Change
This PR introduces the implementation of the new
List
endpoint to theHealth
service in order to list all the services that a certain server is watching to.It also adds generated files for the endpoint and its tests.
I would like to write some tests too but I couldn't run the test suite as it is as I get some errors, any help is appreciated.
Related PR
gRPC-proto added in #2951
Proposal
grpc/proposal#468