allow subscript loader to work on unpacked extension #142
+4
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Why will you unpack it? This extension is supposed to work as packed extension only. |
Contributor
Author
|
I unpacked it so that I could modify it and test it at the same time while it is installed. How are you doing it? |
|
Nevertheless, that patch makes sense. You shouldn't have to fiddle with directories and and URIs (especially involving jar files.) You shouldn't use .jar files anymore anyway, as the extra layer of compression actually reduces performance. |
Contributor
Author
|
Thank you @wagnerand ! 👍 |
Contributor
Author
|
Well I leave it open then, @scrapmac can decide if you want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub script loading did not work on unpacked extension.