Fix Sign In CLS on desktop #14431
Draft
Fix Sign In CLS on desktop #14431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Prevent flicker from 'sign in' to 'my account'
Delay showing right-hand side of the top bar on desktop until the sign-in state is known
Why?
Fix CLS, flickering
TODO
Questions to resolve before opening PR
Promise.raceto show "Sign In state after x seconds?")Update stories to include sign in states
Alternatives? Reserve enough space for both "Sign In" and "Account". This will create some form of misalignment, either with the grid or with the other element in the top bar
Screenshots
CLS
Flicker
Screen.Recording.2025-08-21.at.11.08.14.mov