Google One Tap: Use new Client IDs and secure token transmission #14438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
force-pushed
the
ash/add-google-one-ta
branch
from
05ed9a6 to
0cdeceb
Compare
AshCorr
changed the title
AshCorr
force-pushed
the
ash/add-google-one-ta
branch
from
0cdeceb to
87c16a1
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
AshCorr
force-pushed
the
ash/add-google-one-ta
branch
from
87c16a1 to
83ea337
Compare
AshCorr
force-pushed
the
ash/add-google-one-ta
branch
from
83ea337 to
fb91feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the Client IDs used by Google One Tap to new ones created specifically for Google One Tap
We don't need to use the same client IDs as we use for Google Social Sign in, so we may aswell separate concerns a bit and have a client ID specifically for Google One Tap.
POSTusing a virtual form submission, rather than redirecting to Gateway with the token in the URL.The ID token contains personal information and could be used to login as that user. By using a POST request and putting the token in the form body we can avoid the token appearing in the URL which would likely get logged in quite a few places.
Screenshots
Screen.Recording.2025-08-22.at.09.59.40.mov