Skip to content

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jul 22, 2025

Fixes

Proposed Changes/Todos

  • Add support for surrogate pairs in WindowsOutput and WindowsDriver
  • Also supports 16 Colors with a supported font

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner July 22, 2025 16:55
@BDisp BDisp marked this pull request as draft July 22, 2025 16:55

if (_consoleOut.GetType().Name == "WindowsOutput")
{
newSize = _consoleOut.SetWindowSize (size);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resizing code looks confusing... can you explain why it is necessary to detect change in size and immediately order the output to resize itself again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When windows is resized the buffer isn't correctly resized. So the code force resize the buffer correctly and thus there is no scroll buffer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid this.

devenv_ubd46dG3Un

Copy link
Collaborator Author

@BDisp BDisp Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I recognize that isn't good as is. So, feel free to change all you want.

@BDisp BDisp marked this pull request as ready for review July 31, 2025 00:25
@BDisp BDisp mentioned this pull request Jul 31, 2025
8 tasks
@BDisp
Copy link
Collaborator Author

BDisp commented Aug 4, 2025

I spend much time to deal with resize window issues using VSDebugConsole and WSLg but finally I realized that doesn't worth because seems that them are buggy working as legacy consoles with VTS enabled. From now I'll only rely on cmd.exe and conhost.exe in Windows and gnome-terminal in WSLg, where the existent code NetDriver works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy consoles width shrink on restore after maximize ExtendedCharInfo needs be enhanced to properly deal with all codepoints
2 participants