Filesystem PR #428
Open
Filesystem PR #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
Signed-off-by: msdx321 <[email protected]>
betahxy
reviewed
Oct 4, 2021
| @@ -1,6 +1,9 @@ | |||
| [submodule "src/components/lib/ps/ps"] | |||
| path = src/components/lib/ps/ps | |||
| url = https://github.com/gwsystems/ps.git | |||
Contributor
There was a problem hiding this comment.
I think we could first update the ps port, so we don't need to change the url here
betahxy
reviewed
Oct 4, 2021
| int ret = ext4_fopen(file, path, flags); | ||
| //printc("ret %d\n", ret); | ||
|
|
||
| //printc("mp %p\n", file->mp); |
Contributor
There was a problem hiding this comment.
Removing debug print or using printd() looks better.
betahxy
reviewed
Oct 4, 2021
| void | ||
| cos_init(void) | ||
| { | ||
| for (int i = 0; i < 64; i++) { ns[i] = ps_nsptr_create_slab_fd(); } |
Contributor
There was a problem hiding this comment.
Define 64 to be a meaningful symbol should be better.
betahxy
reviewed
Oct 4, 2021
|
|
||
| void* backing_data[SL_MAX_NUM_THDS]; | ||
| //void* backing_data[SL_MAX_NUM_THDS]; | ||
| void* backing_data[1]; |
Contributor
There was a problem hiding this comment.
Define 1 to be a meaningful symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this Pull Request (PR)
This PR contains interface for block device and filesystem, along with two simple implementation.
Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)
Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship:
Testing
I've tested the code using the following test programs (provide list here):