Skip to content

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Oct 10, 2025

No description provided.

- Change verifyParams parameter from @nonnull to @nullable
- Replace lombok.NonNull with androidx.annotation.NonNull
@CAMOBAP CAMOBAP self-assigned this Oct 10, 2025
@DSergiu DSergiu changed the title Bugfix/verify params nullable fix: verify params nullable Oct 10, 2025
Copy link

github-actions bot commented Oct 10, 2025

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +506.61 -2
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +677.02 +201
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +10.04 +194
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +13.46 -5592
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +37.79 -20

Copy link

github-actions bot commented Oct 10, 2025

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────
      jar │  58.6 KiB │  58.6 KiB │ -49 B 
 manifest │     411 B │     411 B │   0 B 
      res │  78.2 KiB │  78.2 KiB │   0 B 
    other │     989 B │     989 B │   0 B 
──────────┼───────────┼───────────┼───────
    total │ 138.2 KiB │ 138.2 KiB │ -49 B 

 JAR     │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  38 │  38 │  0 (+0 -0) 
 methods │ 556 │ 556 │  0 (+0 -0) 
  fields │ 174 │ 173 │ -1 (+0 -1)
AAR
 size     │ diff  │ path          
──────────┼───────┼───────────────
 58.6 KiB │ -49 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 58.6 KiB │ -49 B │ (total)
JAR
FIELDS:

   old │ new │ diff       
  ─────┼─────┼────────────
   174 │ 173 │ -1 (+0 -1) 
  
  - com.hcaptcha.sdk.HCaptchaWebViewHelper verifyParams: HCaptchaVerifyParams

@e271828- e271828- merged commit f0a4207 into main Oct 13, 2025
11 checks passed
@e271828- e271828- deleted the bugfix/verify-params-nullable branch October 13, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants