Begin creating RawPendingColumnTransaction and switch Column HCB codes to having the Column ID
#10704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sampoder
commented
Jul 30, 2025
davidcornu
reviewed
Jul 30, 2025
db/migrate/20250625003228_create_raw_pending_column_transactions.rb
Outdated
Show resolved
Hide resolved
...ate/20250625004725_add_raw_pending_column_transaction_id_to_canonical_pending_transaction.rb
Show resolved
Hide resolved
|
|
||
| def create_canonical_pending_transaction | ||
| column_account_number = Column::AccountNumber.find_by(column_id: column_transaction["account_number_id"]) | ||
| return unless column_account_number |
There was a problem hiding this comment.
question: When might we run into this scenario? Should we fail louder?
There was a problem hiding this comment.
This is common and we shouldn't fail for this - this is any time a transaction hits our main account number and can't be matched to an event. Examples include internal book transfers and all Stripe transactions.
sampoder
changed the title
RawPendingColumnTransactionRawPendingColumnTransaction and switch Column HCB codes to having the Column ID
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines
+62
to
+64
| # event-specific account numbers. | ||
| return if account_number.nil? | ||
|
|
There was a problem hiding this comment.
Suggested change
| # event-specific account numbers. | |
| return if account_number.nil? | |
| # event-specific account numbers. | |
| return if account_number.nil? | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context behind this implementation is available at #9659.