[User Session] Clear metadata on older sessions #10751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
davidcornu
reviewed
Jun 27, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…hod for clearing old sessions
… method for clearing old sessions
Contributor
Author
|
done! let me know if any further changes are needed, ty! |
garyhtou
reviewed
Jul 9, 2025
Comment on lines
84
to
90
| def clear_metadata! | ||
| update_columns( | ||
| device_info: nil, | ||
| latitude: nil, | ||
| longitude: nil, | ||
| ) | ||
| end |
Member
There was a problem hiding this comment.
Do we want to use update to update! so that callbacks/validations run? Any thoughts @davidcornu?
Member
There was a problem hiding this comment.
Do we want to use
updatetoupdate!so that callbacks/validations run?
Inclined to say yes unless we have a good reason not to.
Member
There was a problem hiding this comment.
Yeah, i'm on the same page.
typo in first message: to -> or*
garyhtou
reviewed
Jul 16, 2025
garyhtou
changed the title
Sarvesh-Mk
pushed a commit
to Sarvesh-Mk/hcb
that referenced
this pull request
Jul 21, 2025
### Closes hackclub#10744 This pull request introduces a new background job to clear outdated user session data and schedules it to run daily. The job ensures sensitive session information is removed for sessions older than one year. Below are the most important changes: ### Addition of a new job: * [`app/jobs/user/clear_old_user_sessions_job.rb`](diffhunk://#diff-19bd9b2978ef88bf9ae1db00fbb346141d92e5d85c4cb816b8949d814f0c4792R1-R21): Added a new job `ClearOldUserSessionsJob` to the `User` namespace. This job iterates through user sessions older than one year and clears sensitive data such as `device_info`, `os_info`, `timezone`, `ip`, and location details (`latitude` and `longitude`). ### Scheduling the job: * [`config/schedule.yml`](diffhunk://#diff-18c4a92c666266e8bead5b6ddb034501022877cdf773c0d337499ed0a7f6d341R175-R179): Scheduled the new `ClearOldUserSessionsJob` to run daily at 3:00 AM with a low priority queue. [Internal discussion](https://hackclub.slack.com/archives/C047Y01MHJQ/p1750259883680629) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gary Tou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10744
This pull request introduces a new background job to clear outdated user session data and schedules it to run daily. The job ensures sensitive session information is removed for sessions older than one year. Below are the most important changes:
Addition of a new job:
app/jobs/user/clear_old_user_sessions_job.rb: Added a new jobClearOldUserSessionsJobto theUsernamespace. This job iterates through user sessions older than one year and clears sensitive data such asdevice_info,os_info,timezone,ip, and location details (latitudeandlongitude).Scheduling the job:
config/schedule.yml: Scheduled the newClearOldUserSessionsJobto run daily at 3:00 AM with a low priority queue.Internal discussion