-
-
Notifications
You must be signed in to change notification settings - Fork 21
Host contact form status icons #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tylerthome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, based on everything we discussed this meets exactly what we wanted out of this effort.
A couple of pending items for our discussion this week:
- Styling - let's get in sync with design here, and where it makes sense we can make some styling configs more dynamic and possibly integrated with Figma(etc) tooling
- Using string values for responses as opposed to strict identifiers
- Navigation based on form step - comment in PR
Thanks for the great work here @mugdhchauhan !
|
|
||
| // eslint-disable-next-line no-case-declarations | ||
| const {emailFieldId, phoneFieldId} = field.linkedFields; | ||
| const {emailFieldId, phoneFieldId} = field.linkedFields!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revisit this soon to decide precisely the behavior we want, and if the ! operator meets our needs (as opposed to a more explicit handling of the condition where linkedFields is null
|
|
||
| <Divider sx={{my: 3}} /> | ||
|
|
||
| {step === 1 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a good place for an enum to leverage TypeScript to the benefit of code readability, TBD pending discussion, not a blocker for this task
Closes #716
What changes did you make?
Rationale behind the changes?
Testing done for these changes
What did you learn or can share that is new?(optional)
user_idrather than creating duplicate entries.phone_numbernullable./completion-status/{user_id}) to drive frontend UI feedback logic.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
Screenshots.pdf