Skip to content

Fix scroll position calculation when navigating between text fields #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix scroll position calculation when navigating between text fields #2139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28165a8
Initial plan
Copilot Sep 19, 2025
f5508fa
Fix scroll position calculation for negative moveUp values
Copilot Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Position.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,18 @@ private extension IQKeyboardManager {
textInputView: textInputView, collectionView: collectionView,
rootSuperview: rootSuperview, layoutGuide: layoutGuide)
} else {
isContinue = textInputViewRectInRootSuperview.minY < layoutGuide.top
// For regular scroll views when not in special table/collection view case
if moveUp > 0 {
// Text field is hidden above, check if scroll view can handle it
isContinue = moveUp > (-scrollView.contentOffset.y - scrollView.contentInset.top)
} else {
// moveUp <= 0, meaning text field needs to scroll down into view
// Check if we have available scroll space to handle this
let availableScrollUpSpace = scrollView.contentOffset.y + scrollView.contentInset.top
isContinue = availableScrollUpSpace > 0 || textInputViewRectInRootSuperview.minY < layoutGuide.top
}

if isContinue {
if isContinue && textInputViewRectInRootSuperview.minY < layoutGuide.top {
moveUp = CGFloat.minimum(0, textInputViewRectInRootSuperview.minY - layoutGuide.top)
}
}
Expand All @@ -455,12 +464,35 @@ private extension IQKeyboardManager {
if let lastViewRect: CGRect = lastView.superview?.convert(lastView.frame, to: scrollView) {

// Calculating the expected Y offset from move and scrollView's contentOffset.
let minimumMovement: CGFloat = CGFloat.minimum(scrollView.contentOffset.y, -moveUp)
var suggestedOffsetY: CGFloat = scrollView.contentOffset.y - minimumMovement
var suggestedOffsetY: CGFloat
if moveUp < 0 {
// When moveUp is negative (need to scroll down), we should try to scroll up first
// by reducing contentOffset.y as much as possible
let availableScrollUpSpace = scrollView.contentOffset.y + scrollView.contentInset.top
let requiredScrollDown = -moveUp
if availableScrollUpSpace >= requiredScrollDown {
// We can accommodate the full requirement by scrolling up
suggestedOffsetY = scrollView.contentOffset.y - requiredScrollDown
} else {
// We can only scroll up by the available space
suggestedOffsetY = -scrollView.contentInset.top
}
} else {
// Original logic for positive moveUp
let minimumMovement: CGFloat = CGFloat.minimum(scrollView.contentOffset.y, -moveUp)
suggestedOffsetY = scrollView.contentOffset.y - minimumMovement
}

// Rearranging the expected Y offset according to the view.
suggestedOffsetY = CGFloat.minimum(suggestedOffsetY, lastViewRect.minY)

// Update moveUp based on how much we can actually scroll
if moveUp < 0 {
// When moveUp is negative, adjust it based on how much we can actually scroll
let actualScrollChange = scrollView.contentOffset.y - suggestedOffsetY
moveUp += actualScrollChange
}

updateSuggestedOffsetYAndMoveUp(suggestedOffsetY: &suggestedOffsetY, moveUp: &moveUp,
isScrollableTextInputView: isScrollableTextInputView,
nextScrollView: nextScrollView, textInputView: textInputView,
Expand Down