Skip to content

Conversation

MubeenMohammed
Copy link

@MubeenMohammed MubeenMohammed commented Sep 26, 2025

Tickets:

  • HCK-

List of changes:

  • Added the background svg from figma
  • Changed the About and Sponsor section to match the current design
Screen Shot 2025-09-26 at 2 36 35 AM Screen Shot 2025-09-26 at 2 37 34 AM

Type of change:

  • Bug fix
  • New feature
  • Breaking change
  • New release
  • Requires a documentation update

How did you do this?

Why are you choosing this approach?

Questions for code reviewers?

PR Checklist:

  • Merged develop branch (before testing)
  • Ran yarn format to format code
  • Listed change(s) in the Changelog
  • Tested all links in project relevant browsers
  • Tested all links on different screen sizes
  • Referenced all useful info (issues, tasks, etc)

Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mchacks13 Ready Ready Preview Comment Oct 17, 2025 5:10am

@tektaxi
Copy link
Contributor

tektaxi commented Sep 27, 2025

This is how it previews on my MacBook screen. Basically unreadable text because it gets shifted on top of the green and white when the screen size decreases. May need to use some media queries to determine text placement. Sponsor section text also hard to read.
Screenshot 2025-09-26 at 20 59 09

@MubeenMohammed
Copy link
Author

MubeenMohammed commented Oct 15, 2025

The design specification for the footer was not provided in the Figma file, so I made some assumptions about what it would look like.

We are still waiting on the campfire and portal assets files. I already sent a message to the design channel. We will update those as soon as we receive the files.

Everything else seems to be completed

This reverts commit 258bf23.
@tektaxi
Copy link
Contributor

tektaxi commented Oct 19, 2025

I'm a bit confused about the "past sponsors" section at the bottom. still seems to be in the old style? should we delete that? we don't have a design for it, right?

@tektaxi
Copy link
Contributor

tektaxi commented Oct 19, 2025

will approve and merge into develop but here are some things that must be fixed in future PRs before we push to prod:

  • the date in the FAQ is wrong.
  • the "other ways to get involved" text needs to be real (not placeholder)
  • what to do with "past sponsors" (will become current sponsors) section?

Copy link
Contributor

@tektaxi tektaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will need to fix minor content things before we merge to main. looks amazing!! tysm Ethan and Mubeen for all the hard work here

@tektaxi tektaxi merged commit bd0ce20 into develop Oct 19, 2025
2 checks passed
@MubeenMohammed MubeenMohammed deleted the revamp/about_sponsor branch October 22, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants