-
Notifications
You must be signed in to change notification settings - Fork 0
revamp of about and sponsor section #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The design specification for the footer was not provided in the Figma file, so I made some assumptions about what it would look like. We are still waiting on the campfire and portal assets files. I already sent a message to the design channel. We will update those as soon as we receive the files. Everything else seems to be completed |
This reverts commit 258bf23.
I'm a bit confused about the "past sponsors" section at the bottom. still seems to be in the old style? should we delete that? we don't have a design for it, right? |
will approve and merge into develop but here are some things that must be fixed in future PRs before we push to prod:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will need to fix minor content things before we merge to main. looks amazing!! tysm Ethan and Mubeen for all the hard work here
Tickets:
List of changes:
Type of change:
How did you do this?
Why are you choosing this approach?
Questions for code reviewers?
PR Checklist:
develop
branch (before testing)yarn format
to format code