Skip to content

HCK-13438: invalid comment #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitaliiBedletskyi merged 2 commits into from
Nov 10, 2025
Merged

HCK-13438: invalid comment #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e42ab8d
fix: comment out only valid statements
chulanovskyi-bs Nov 10, 2025
bf0f03f
chore: formatting
chulanovskyi-bs Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forward_engineering/helpers/commentIfDeactivated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const BEFORE_DEACTIVATED_STATEMENT = '-- ';
const REG_FOR_MULTILINE_COMMENT = /(\n\/\*\n[\s\S]*?\n\s\*\/\n)|((\n\/\*\n[\s\S]*?\n\s\*\/)$)/gi;

const commentIfDeactivated = (statement, data, isPartOfLine) => {
if (data.isActivated === false) {
if (data.isActivated === false && statement) {
if (isPartOfLine) {
return '/* ' + statement + ' */';
} else if (statement.includes('\n')) {
Expand Down
2 changes: 1 addition & 1 deletion forward_engineering/helpers/general.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const getTableOptions = options => {
return '';
}

return `WITH (\n\t${optionsStatements.join(',\n\t')}\n)`;
return ` WITH (\n\t${optionsStatements.join(',\n\t')}\n)`;
};

const hasType = type => {
Expand Down