Vendor JS dependencies, for offline support #1354
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was created by running: ```sh curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/debug.js -o primer-miso/frontend/debug.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/fd.js -o primer-miso/frontend/fd.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/fs_mem.js -o primer-miso/frontend/fs_mem.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/fs_opfs.js -o primer-miso/frontend/fs_opfs.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/index.js -o primer-miso/frontend/browser_wasi_shim.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/strace.js -o primer-miso/frontend/strace.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/wasi_defs.js -o primer-miso/frontend/wasi_defs.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/wasi.js -o primer-miso/frontend/wasi.js curl https://cdn.jsdelivr.net/npm/@bjorn3/[email protected]/dist/wasi.js -o primer-miso/frontend/wasi.js ``` Signed-off-by: George Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit silly that currently the only thing that stops the app from working without an internet connection is downloading a JS shim from some CDN on initial load. I don't even really know what this JS code does: the import line is just copied straight from Tweag's Miso Wasm examples repo.
Vendoring like this isn't really the best option. We should probably download as part of the build process instead. This is really just here as a reminder that we should do something about this, as well as being some code to pull in temporarily at the start of train journeys...