-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add br
& zstd
to supported compression 🗜️ algos
#4549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bricss
wants to merge
19
commits into
hapijs:master
Choose a base branch
from
bricss:feat/add-br+sztd-with-priority-opts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8dd643f
feat: add brotli to supported compression 🗜️
bricss 6b513c3
chore: address comments 📝
bricss a8d70ec
chore: address comments 📝
bricss 0d6537b
feat: add br & zstd to supported compression 🗜️ algos
bricss 0939808
fix: cure ⚕️ ci
bricss 825f9c6
fix: fixate 🪛 types
bricss 78f5cff
feat: adjust default priority 🎛️
bricss c5af64e
feat: make built-in `br` & `zstd` algos opt-in and disabled by default
bricss 378a78e
chore: brush up 💄
bricss 82f3108
feat: add support for compression 🗜 options 🎛️
bricss 3502cc0
fix: fixate 🪛 types
bricss 9264708
fix: fixate 🪛 types, take 2 🎬
bricss c0da437
chore: clean up 🧽
bricss 0e85c2d
feat: address comments 📝
bricss 5c9baea
feat: reverse ↩️ engine 🚂 version
bricss af576f5
feat: reverse ↩️ ci min node version 🔢
bricss 6d28443
feat: betterment 💈
bricss c24f5ca
feat: address comments 📝
bricss f07fa73
fix: cure 🩹 code coverage
bricss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to update the common encoding with
'gzip, deflate, br, zstd'
, as this is used by both Chrome and Firefox. This can go in a separate PR.