Skip to content

Conversation

@mattboutet
Copy link
Member

No description provided.

@mattboutet mattboutet requested a review from devinivy February 3, 2023 23:38
@coveralls
Copy link

coveralls commented Feb 20, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling 10e7246 on mattboutet:marked-term into 4661f17 on hapipal:master.

package.json Outdated
"marked": "1.x.x",
"marked-terminal": "4.x.x",
"marked": "4.0.16",
"marked-terminal": "5.x.x",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only v5 marked-terminal versions that have support for CJS usage is v5.1.0+, so I think we'll want something like this:

Suggested change
"marked-terminal": "5.x.x",
"marked-terminal": "^5.1.0",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - I'll push up a fix shortly.

"glob": "7.x.x",
"marked": "1.x.x",
"marked-terminal": "4.x.x",
"marked": "4.0.16",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a special reason this version is pinned, or can we use ^4.0.16?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown parsing change comes in at 4.0.17, which breaks some of hpal's tests, so I pinned it to this specific version.

@mattboutet
Copy link
Member Author

It turns out in npm v9 an aborted init will still have exit code 0, so there's a broken test with node v18. Working on a rewrite of the test in question now.

…at when running hpal new. Also update lab to pick up new global leak handling
@satcheluniverse
Copy link

@devinivy I know this is over 2 years old, but would getting this merged be a possibility? If not, would you be open to others helping maintain the hpal suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants