Skip to content

Conversation

shawnaws
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No

Description

This adds support for leveraging a Witness Region in DynamoDB Global Tables with Mutli-Region Strong Consistency.

Relations

Closes #43612

References

Output from Acceptance Testing

% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTable_Replica_MRSC_witness
make: Fixing source code with gofmt...
gofmt -s -w ./internal ./names ./.ci/providerlint/helper ./.ci/providerlint/main.go ./.ci/providerlint/passes
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Building provider...
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_Replica_MRSC_witness'  -timeout 360m -vet=off
2025/08/14 16:33:27 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/14 16:33:27 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_doubleAddCMK
=== PAUSE TestAccDynamoDBTable_Replica_MRSC_witness_doubleAddCMK
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_pitr
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_pitr (216.84s)
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_pitrKMS
=== PAUSE TestAccDynamoDBTable_Replica_MRSC_witness_pitrKMS
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_tags_updateIsPropagated_oneOfTwo
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_tags_updateIsPropagated_oneOfTwo (243.75s)
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_tags_updateIsPropagated_twoOfTwo
^[[C--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_tags_updateIsPropagated_twoOfTwo (233.29s)
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_tags_propagateToAddedReplica
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_tags_propagateToAddedReplica (227.64s)
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_tags_notPropagatedToAddedReplica
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_tags_notPropagatedToAddedReplica (235.11s)
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_tags_nonPropagatedTagsAreUnmanaged
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_tags_nonPropagatedTagsAreUnmanaged (236.11s)
=== RUN   TestAccDynamoDBTable_Replica_MRSC_witness_tagsUpdate
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_tagsUpdate (306.48s)
=== CONT  TestAccDynamoDBTable_Replica_MRSC_witness_doubleAddCMK
=== CONT  TestAccDynamoDBTable_Replica_MRSC_witness_pitrKMS
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_pitrKMS (325.32s)
--- PASS: TestAccDynamoDBTable_Replica_MRSC_witness_doubleAddCMK (656.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   2363.769s
...

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Aug 15, 2025
@shawnaws shawnaws force-pushed the f/ddb-mrsc-witness-updates branch from cf24b6b to 7e6c0a6 Compare August 15, 2025 15:57
@shawnaws shawnaws marked this pull request as ready for review August 15, 2025 16:59
@shawnaws shawnaws requested a review from a team as a code owner August 15, 2025 16:59
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamo DB MRSC table support witness flag not implemented
2 participants