Skip to content

Conversation

shawnaws
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No

Description

Add support for CloudWatch Contributor Insights Mode for DynamoDB (released in go sdk dynamodb 1.48.0)

Relations

Closes #43913

References

Output from Acceptance Testing

% make testacc PKG=dynamodb TESTS=TestAccDynamoDBContributorInsights
make: Fixing source code with gofmt...
gofmt -s -w ./internal ./names ./.ci/providerlint/helper ./.ci/providerlint/main.go ./.ci/providerlint/passes
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Building provider...
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBContributorInsights'  -timeout 360m -vet=off
2025/08/15 11:05:24 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/15 11:05:24 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDynamoDBContributorInsights_basic
=== PAUSE TestAccDynamoDBContributorInsights_basic
=== RUN   TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled
=== PAUSE TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled
=== RUN   TestAccDynamoDBContributorInsights_ModeThrottledOnly
=== PAUSE TestAccDynamoDBContributorInsights_ModeThrottledOnly
=== RUN   TestAccDynamoDBContributorInsights_disappears
=== PAUSE TestAccDynamoDBContributorInsights_disappears
=== CONT  TestAccDynamoDBContributorInsights_basic
=== CONT  TestAccDynamoDBContributorInsights_ModeThrottledOnly
=== CONT  TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled
=== CONT  TestAccDynamoDBContributorInsights_disappears
--- PASS: TestAccDynamoDBContributorInsights_disappears (55.17s)
--- PASS: TestAccDynamoDBContributorInsights_basic (70.88s)
--- PASS: TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled (73.08s)
--- PASS: TestAccDynamoDBContributorInsights_ModeThrottledOnly (74.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   81.538s

...

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Aug 15, 2025
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Aug 15, 2025
@shawnaws shawnaws marked this pull request as ready for review August 15, 2025 16:59
@shawnaws shawnaws requested a review from a team as a code owner August 15, 2025 16:59
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 22, 2025
@ewbankkit ewbankkit self-assigned this Aug 22, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 22, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDynamoDBContributorInsights_' PKG=dynamodb ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/dynamodb/... -v -count 1 -parallel 3  -run=TestAccDynamoDBContributorInsights_ -timeout 360m -vet=off
2025/08/22 15:59:41 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/22 15:59:41 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDynamoDBContributorInsights_basic
=== PAUSE TestAccDynamoDBContributorInsights_basic
=== RUN   TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled
=== PAUSE TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled
=== RUN   TestAccDynamoDBContributorInsights_ModeThrottledOnly
=== PAUSE TestAccDynamoDBContributorInsights_ModeThrottledOnly
=== RUN   TestAccDynamoDBContributorInsights_disappears
=== PAUSE TestAccDynamoDBContributorInsights_disappears
=== CONT  TestAccDynamoDBContributorInsights_basic
=== CONT  TestAccDynamoDBContributorInsights_ModeThrottledOnly
=== CONT  TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled
--- PASS: TestAccDynamoDBContributorInsights_ModeThrottledOnly (63.01s)
=== CONT  TestAccDynamoDBContributorInsights_disappears
--- PASS: TestAccDynamoDBContributorInsights_ModeAccessedAndThrottled (63.09s)
--- PASS: TestAccDynamoDBContributorInsights_basic (66.30s)
--- PASS: TestAccDynamoDBContributorInsights_disappears (50.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	119.279s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@shawnaws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b5e3f72 into hashicorp:main Aug 25, 2025
44 checks passed
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.11.0 milestone Aug 25, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 28, 2025
Copy link
Contributor

This functionality has been released in v6.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/M Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CloudWatch Contributor Insights Mode for Dynamo DB
3 participants