Skip to content

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 19, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Closes #31705.
Closes #42585.
Closes #38705.

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/L Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 19, 2025
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Aug 21, 2025
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Aug 27, 2025
@ewbankkit ewbankkit force-pushed the b-servicecatalog-pp-status branch from 8de0ea7 to c21a1b0 Compare August 28, 2025 18:13
% make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_basic' PKG=servicecatalog
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/servicecatalog/... -v -count 1 -parallel 20  -run=TestAccServiceCatalogProvisionedProduct_basic -timeout 360m -vet=off
2025/08/28 14:25:42 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/28 14:25:42 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (91.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	97.019s
@ewbankkit
Copy link
Contributor

My final commit (ef2c3ac) enables the state refresh if Update results in TAINTED state, but the test is still failing:

% make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate' PKG=servicecatalog
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/servicecatalog/... -v -count 1 -parallel 20  -run=TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate -timeout 360m -vet=off
2025/08/28 15:10:33 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/28 15:10:33 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate
=== PAUSE TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate
=== CONT  TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate
    provisioned_product_test.go:1009: Step 3/4 error: Pre-apply plan check(s) failed:
        'aws_servicecatalog_provisioned_product.test' - expected Update, got action(s): [no-op]
--- FAIL: TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate (187.72s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	193.273s
FAIL
make: *** [testacc] Error 1

I think that this is because the attribute that is changed in the step is provisioning_parameters and that is write-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants