-
Notifications
You must be signed in to change notification settings - Fork 9.7k
service cat debuggery #43956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
service cat debuggery #43956
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
…M permissions to propagate
…ws_partition data source'.
8de0ea7
to
c21a1b0
Compare
% make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_basic' PKG=servicecatalog make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.6 test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run=TestAccServiceCatalogProvisionedProduct_basic -timeout 360m -vet=off 2025/08/28 14:25:42 Creating Terraform AWS Provider (SDKv2-style)... 2025/08/28 14:25:42 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccServiceCatalogProvisionedProduct_basic === PAUSE TestAccServiceCatalogProvisionedProduct_basic === CONT TestAccServiceCatalogProvisionedProduct_basic --- PASS: TestAccServiceCatalogProvisionedProduct_basic (91.58s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog 97.019s
My final commit (ef2c3ac) enables the state refresh if Update results in TAINTED state, but the test is still failing: % make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate' PKG=servicecatalog
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run=TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate -timeout 360m -vet=off
2025/08/28 15:10:33 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/28 15:10:33 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate
=== PAUSE TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate
=== CONT TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate
provisioned_product_test.go:1009: Step 3/4 error: Pre-apply plan check(s) failed:
'aws_servicecatalog_provisioned_product.test' - expected Update, got action(s): [no-op]
--- FAIL: TestAccServiceCatalogProvisionedProduct_retryTaintedUpdate (187.72s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog 193.273s
FAIL
make: *** [testacc] Error 1 I think that this is because the attribute that is changed in the step is |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Relations
Closes #31705.
Closes #42585.
Closes #38705.
Output from Acceptance Testing