Skip to content

[WIP] List Resource initial implementation #43960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

[WIP] List Resource initial implementation #43960

wants to merge 28 commits into from
+1,917 −657

Conversation

gdavison
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

List Resource initial implementation.

Contains some cruft files that will need to be removed.

gdavison added 27 commits August 19, 2025 16:28
@gdavison
Updates dependencies
58418b5
@gdavison
Consolidates interceptedHandler tests
f4df5ef
@gdavison
Adds ListResource interceptors and handles Before interceptors
3c6effd
@gdavison
Handles successful inner function
2d123e4
@gdavison
Handles errors on inner function
f48273d
@gdavison
Creates iter.Null
94def71
@gdavison
Renames listResourceSchemaInterceptor schema function
4488add
@gdavison
Adds region interceptor for List Resources
0628d91
@gdavison
Adds types.ServicePackageListResource
737f235
@gdavison
Adds tests for AssertSingleValueResult
da4d2ff
@gdavison
Adds AssertSingleValueResultIterErr
f778a0a
@gdavison
Adds iter.Null2
8cac22c
@gdavison
Adds shared List Resource region attribute
271e0f3
@gdavison
Adds default region interceptor for List Resources
0447e94
@gdavison
Adds Identity to List Resource spec
60ffb86
@gdavison
Adds iterator listJobQueues
37d3837
@gdavison
Removes unused default region interceptor
5d6f7e6
@gdavison
Uses listJobQueues for sweeper
6de36ba
@gdavison
Updates dependencies
4a7b622
@gdavison
Renames inttypes.ServicePackageListResource to `ServicePackageFrame…
6a1ad30 
…workListResource`
@gdavison
Adds Tags to ServicePackageFrameworkResource
daa1d7f
@gdavison
Updates github.com/hashicorp/terraform-plugin-testing dependency
e706526
@gdavison
Adds WIP List code for aws_batch_job_queue
ad4c9d9
@gdavison
Registers List Resource for aws_batch_job_queue
e0cd63d
@gdavison
WIP acceptance tests
b8d6e8b
@gdavison
Manual test configurations
ff7a725
@gdavison
Formatting
47e53f6
@github-actions GitHub Actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/batch Issues and PRs that pertain to the batch service. labels Aug 19, 2025
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. sweeper Pertains to changes to or issues with the sweeper. skaff Issues and pull requested related to the skaff tool size/XL Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. service/batch Issues and PRs that pertain to the batch service. size/XL Managed by automation to categorize the size of a PR. skaff Issues and pull requested related to the skaff tool sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gdavison