Skip to content

Conversation

tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented Aug 21, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • Added the ipv6_allowed_for_dual_stack argument to vpc_config.
  • In the acceptance tests, the expected value of the default run_config.memory_in_mb was updated to pass the tests, since the default value appears to have changed in the AWS API.

Relations

Closes #43979

References

https://docs.aws.amazon.com/AmazonSynthetics/latest/APIReference/API_VpcConfigInput.html#synthetics-Type-VpcConfigInput-Ipv6AllowedForDualStack

Output from Acceptance Testing

$ make testacc TESTS=TestAccSyntheticsCanary_ PKG=synthetics
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_'  -timeout 360m -vet=off
2025/08/22 07:44:01 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/22 07:44:01 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSyntheticsCanary_basic
=== PAUSE TestAccSyntheticsCanary_basic
=== RUN   TestAccSyntheticsCanary_artifactEncryption
=== PAUSE TestAccSyntheticsCanary_artifactEncryption
=== RUN   TestAccSyntheticsCanary_runtimeVersion
=== PAUSE TestAccSyntheticsCanary_runtimeVersion
=== RUN   TestAccSyntheticsCanary_rate
=== PAUSE TestAccSyntheticsCanary_rate
=== RUN   TestAccSyntheticsCanary_startCanary
=== PAUSE TestAccSyntheticsCanary_startCanary
=== RUN   TestAccSyntheticsCanary_StartCanary_codeChanges
=== PAUSE TestAccSyntheticsCanary_StartCanary_codeChanges
=== RUN   TestAccSyntheticsCanary_s3
=== PAUSE TestAccSyntheticsCanary_s3
=== RUN   TestAccSyntheticsCanary_run
=== PAUSE TestAccSyntheticsCanary_run
=== RUN   TestAccSyntheticsCanary_runTracing
=== PAUSE TestAccSyntheticsCanary_runTracing
=== RUN   TestAccSyntheticsCanary_runEnvironmentVariables
=== PAUSE TestAccSyntheticsCanary_runEnvironmentVariables
=== RUN   TestAccSyntheticsCanary_vpc
=== PAUSE TestAccSyntheticsCanary_vpc
=== RUN   TestAccSyntheticsCanary_vpcIpv6AllowedForDualStack
=== PAUSE TestAccSyntheticsCanary_vpcIpv6AllowedForDualStack
=== RUN   TestAccSyntheticsCanary_tags
=== PAUSE TestAccSyntheticsCanary_tags
=== RUN   TestAccSyntheticsCanary_disappears
=== PAUSE TestAccSyntheticsCanary_disappears
=== CONT  TestAccSyntheticsCanary_basic
=== CONT  TestAccSyntheticsCanary_run
=== CONT  TestAccSyntheticsCanary_vpcIpv6AllowedForDualStack
=== CONT  TestAccSyntheticsCanary_startCanary
=== CONT  TestAccSyntheticsCanary_runtimeVersion
=== CONT  TestAccSyntheticsCanary_s3
=== CONT  TestAccSyntheticsCanary_StartCanary_codeChanges
=== CONT  TestAccSyntheticsCanary_rate
=== CONT  TestAccSyntheticsCanary_artifactEncryption
=== CONT  TestAccSyntheticsCanary_runEnvironmentVariables
=== CONT  TestAccSyntheticsCanary_vpc
=== CONT  TestAccSyntheticsCanary_runTracing
=== CONT  TestAccSyntheticsCanary_tags
=== CONT  TestAccSyntheticsCanary_disappears
--- PASS: TestAccSyntheticsCanary_tags (99.84s)
--- PASS: TestAccSyntheticsCanary_runTracing (150.43s)
--- PASS: TestAccSyntheticsCanary_startCanary (151.28s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (165.98s)
--- PASS: TestAccSyntheticsCanary_run (178.38s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (218.24s)
--- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (233.70s)
--- PASS: TestAccSyntheticsCanary_disappears (412.99s)
--- PASS: TestAccSyntheticsCanary_s3 (473.83s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (694.43s)
--- PASS: TestAccSyntheticsCanary_basic (739.15s)
--- PASS: TestAccSyntheticsCanary_rate (766.01s)
--- PASS: TestAccSyntheticsCanary_vpc (2147.67s)
--- PASS: TestAccSyntheticsCanary_vpcIpv6AllowedForDualStack (2267.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 2272.326s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/synthetics Issues and PRs that pertain to the synthetics service. size/M Managed by automation to categorize the size of a PR. labels Aug 21, 2025
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Aug 21, 2025
@tabito-hara tabito-hara marked this pull request as ready for review August 22, 2025 01:26
@tabito-hara tabito-hara requested a review from a team as a code owner August 22, 2025 01:26
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 22, 2025
@ewbankkit ewbankkit self-assigned this Aug 22, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 22, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSyntheticsCanary_basic\|TestAccSyntheticsCanary_vpc' PKG=synthetics ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/synthetics/... -v -count 1 -parallel 3  -run=TestAccSyntheticsCanary_basic\|TestAccSyntheticsCanary_vpc -timeout 360m -vet=off
2025/08/22 14:58:01 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/22 14:58:01 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSyntheticsCanary_basic
=== PAUSE TestAccSyntheticsCanary_basic
=== RUN   TestAccSyntheticsCanary_vpc
=== PAUSE TestAccSyntheticsCanary_vpc
=== RUN   TestAccSyntheticsCanary_vpcIPv6AllowedForDualStack
=== PAUSE TestAccSyntheticsCanary_vpcIPv6AllowedForDualStack
=== CONT  TestAccSyntheticsCanary_basic
=== CONT  TestAccSyntheticsCanary_vpcIPv6AllowedForDualStack
=== CONT  TestAccSyntheticsCanary_vpc
--- PASS: TestAccSyntheticsCanary_basic (443.93s)
--- PASS: TestAccSyntheticsCanary_vpcIPv6AllowedForDualStack (1996.93s)
--- PASS: TestAccSyntheticsCanary_vpc (1997.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	2002.955s

@ewbankkit
Copy link
Contributor

@tabito-hara Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 293ec1f into hashicorp:main Aug 22, 2025
47 checks passed
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.11.0 milestone Aug 22, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 28, 2025
Copy link
Contributor

This functionality has been released in v6.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/synthetics Issues and PRs that pertain to the synthetics service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Ipv6AllowedForDualStack to vpc_config of aws_synthetics_canary
2 participants