Skip to content

fix(lightsail): Handle wildcard DNS entries with escaped asterisks #44588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −1
Open

fix(lightsail): Handle wildcard DNS entries with escaped asterisks #44588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87da2b3
fix(lightsail): Handle wildcard DNS entries with escaped asterisks
alvarolb Oct 8, 2025
82e82d6
Add changelog entry for #44588
alvarolb Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/44588.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_lightsail_domain_entry: Fix wildcard DNS entries failing with "empty result" error due to escaped asterisks
```
14 changes: 13 additions & 1 deletion internal/service/lightsail/domain_entry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,11 @@ func expandDomainEntryName(name, domainName string) string {
func flattenDomainEntryName(name, domainName string) string {
rn := strings.ToLower(strings.TrimSuffix(name, "."))
domainName = strings.TrimSuffix(domainName, ".")

// AWS Lightsail returns wildcard entries with escaped asterisks (\052)
// Convert back to asterisks for consistency with user input
rn = strings.ReplaceAll(rn, "\\052", "*")

if strings.HasSuffix(rn, domainName) {
rn = strings.TrimSuffix(rn, fmt.Sprintf(".%s", domainName))
}
Expand Down Expand Up @@ -380,7 +385,14 @@ func FindDomainEntryById(ctx context.Context, conn *lightsail.Client, id string)
entryExists := false

for _, n := range out.Domain.DomainEntries {
if entryName == aws.ToString(n.Name) && recordType == aws.ToString(n.Type) && recordTarget == aws.ToString(n.Target) {
apiName := aws.ToString(n.Name)

// AWS Lightsail returns wildcard entries with escaped asterisks (\052)
// Normalize both names for comparison to handle this encoding
normalizedEntryName := strings.ReplaceAll(entryName, "*", "\\052")
nameMatches := entryName == apiName || normalizedEntryName == apiName

if nameMatches && recordType == aws.ToString(n.Type) && recordTarget == aws.ToString(n.Target) {
entry = n
entryExists = true
break
Expand Down
Loading