Skip to content

Conversation

tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented Oct 10, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Add ip_address_type argument to aws_ec2_instance_connect_endpoint resource.

  • Acceptance tests for each value of ip_address_type can be run in parallel since the Update function is not implemented and each test requires resource recreation.

Relations

Closes #44610

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateInstanceConnectEndpoint.html

Output from Acceptance Testing

$ ACCTEST_PARALLELISM=5 make testacc TESTS='TestAccEC2InstanceConnectEndpoint_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_ec2_instance_connect_endpoint-add_ip_address_type 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccEC2InstanceConnectEndpoint_'  -timeout 360m -vet=off
2025/10/10 23:52:31 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/10 23:52:31 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2InstanceConnectEndpoint_basic
=== PAUSE TestAccEC2InstanceConnectEndpoint_basic
=== RUN   TestAccEC2InstanceConnectEndpoint_disappears
=== PAUSE TestAccEC2InstanceConnectEndpoint_disappears
=== RUN   TestAccEC2InstanceConnectEndpoint_tags
=== PAUSE TestAccEC2InstanceConnectEndpoint_tags
=== RUN   TestAccEC2InstanceConnectEndpoint_securityGroupIDs
=== PAUSE TestAccEC2InstanceConnectEndpoint_securityGroupIDs
=== RUN   TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv4
=== PAUSE TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv4
=== RUN   TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv6
=== PAUSE TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv6
=== RUN   TestAccEC2InstanceConnectEndpoint_ipAddressTypeDualStack
=== PAUSE TestAccEC2InstanceConnectEndpoint_ipAddressTypeDualStack
=== RUN   TestAccEC2InstanceConnectEndpoint_fipsRegion
=== PAUSE TestAccEC2InstanceConnectEndpoint_fipsRegion
=== RUN   TestAccEC2InstanceConnectEndpoint_nonFIPSRegion
=== PAUSE TestAccEC2InstanceConnectEndpoint_nonFIPSRegion
=== CONT  TestAccEC2InstanceConnectEndpoint_basic
=== CONT  TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv6
=== CONT  TestAccEC2InstanceConnectEndpoint_fipsRegion
=== CONT  TestAccEC2InstanceConnectEndpoint_ipAddressTypeDualStack
=== CONT  TestAccEC2InstanceConnectEndpoint_nonFIPSRegion
    ec2_instance_connect_endpoint_test.go:287: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [ap-northeast-1]
--- SKIP: TestAccEC2InstanceConnectEndpoint_nonFIPSRegion (7.20s)
=== CONT  TestAccEC2InstanceConnectEndpoint_securityGroupIDs
--- PASS: TestAccEC2InstanceConnectEndpoint_fipsRegion (369.93s)
=== CONT  TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv4
--- PASS: TestAccEC2InstanceConnectEndpoint_securityGroupIDs (364.46s)
=== CONT  TestAccEC2InstanceConnectEndpoint_tags
--- PASS: TestAccEC2InstanceConnectEndpoint_basic (380.21s)
=== CONT  TestAccEC2InstanceConnectEndpoint_disappears
--- PASS: TestAccEC2InstanceConnectEndpoint_ipAddressTypeDualStack (390.68s)
--- PASS: TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv6 (390.73s)
--- PASS: TestAccEC2InstanceConnectEndpoint_disappears (358.63s)
--- PASS: TestAccEC2InstanceConnectEndpoint_ipAddressTypeIPv4 (382.02s)
--- PASS: TestAccEC2InstanceConnectEndpoint_tags (1063.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1439.801s

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. labels Oct 10, 2025
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Oct 10, 2025
@tabito-hara tabito-hara marked this pull request as ready for review October 10, 2025 15:37
@tabito-hara tabito-hara requested a review from a team as a code owner October 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support IpAddressType with aws_ec2_instance_connect_endpoint

1 participant