[New Data Source]: aws_vpn_connection: Add new data source to fetch information about an EC2 VPN Connection. #44622

subham-ibmhc · 2025-10-10T23:19:32Z

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Add new data source aws_vpn_connection to retrieve information on an EC2 VPN Connection.
- Implemented using the DescribeVPNConnections API.
  - Accepts vpn_connection_id and filter as arguments.

Relations

Closes #3593

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeVpnConnections.html

Output from Acceptance Testing

% make testacc TESTS=TestAccEC2VpnConnectionDataSource_ PKG=ec2 make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-aws_ec2_vpn_connection-new-data-source 🌿... TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2VpnConnectionDataSource_' -timeout 360m -vet=off 2025/10/09 20:21:06 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/09 20:21:06 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccEC2VpnConnectionDataSource_basic
=== PAUSE TestAccEC2VpnConnectionDataSource_basic
=== RUN TestAccEC2VpnConnectionDataSource_byFilter
=== PAUSE TestAccEC2VpnConnectionDataSource_byFilter
=== RUN TestAccEC2VpnConnectionDataSource_nonExistentId
=== PAUSE TestAccEC2VpnConnectionDataSource_nonExistentId
=== RUN TestAccEC2VpnConnectionDataSource_noInput
=== PAUSE TestAccEC2VpnConnectionDataSource_noInput
=== CONT TestAccEC2VpnConnectionDataSource_basic
=== CONT TestAccEC2VpnConnectionDataSource_nonExistentId
=== CONT TestAccEC2VpnConnectionDataSource_noInput
=== CONT TestAccEC2VpnConnectionDataSource_byFilter
--- PASS: TestAccEC2VpnConnectionDataSource_noInput (3.85s)
--- PASS: TestAccEC2VpnConnectionDataSource_nonExistentId (5.41s)
--- PASS: TestAccEC2VpnConnectionDataSource_byFilter (258.74s)
--- PASS: TestAccEC2VpnConnectionDataSource_basic (593.10s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 597.880s

% make testacc TESTS=TestAccEC2VpnConnectionDataSource_ PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-aws_ec2_vpn_connection-new-data-source 🌿... TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2VpnConnectionDataSource_' -timeout 360m -vet=off 2025/10/09 20:21:06 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/09 20:21:06 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccEC2VpnConnectionDataSource_basic === PAUSE TestAccEC2VpnConnectionDataSource_basic === RUN TestAccEC2VpnConnectionDataSource_byFilter === PAUSE TestAccEC2VpnConnectionDataSource_byFilter === RUN TestAccEC2VpnConnectionDataSource_nonExistentId === PAUSE TestAccEC2VpnConnectionDataSource_nonExistentId === RUN TestAccEC2VpnConnectionDataSource_noInput === PAUSE TestAccEC2VpnConnectionDataSource_noInput === CONT TestAccEC2VpnConnectionDataSource_basic === CONT TestAccEC2VpnConnectionDataSource_nonExistentId === CONT TestAccEC2VpnConnectionDataSource_noInput === CONT TestAccEC2VpnConnectionDataSource_byFilter --- PASS: TestAccEC2VpnConnectionDataSource_noInput (3.85s) --- PASS: TestAccEC2VpnConnectionDataSource_nonExistentId (5.41s) --- PASS: TestAccEC2VpnConnectionDataSource_byFilter (258.74s) --- PASS: TestAccEC2VpnConnectionDataSource_basic (593.10s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 597.880s

github-actions · 2025-10-10T23:19:47Z

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
Please see our prioritization guide for additional information on how the maintainers handle prioritization.
Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

internal/service/ec2/vpnsite_connection_data_source.go

internal/service/ec2/vpn_connection_data_source.go

website/docs/d/vpn_connection.html.markdown

go.mod

```console % make t K=ec2 T=TestAccEC2VPNConnectionDataSource_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-aws_ec2_vpn_connection-new-data-source 🌿... TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2VPNConnectionDataSource_' -timeout 360m -vet=off 2025/10/14 10:23:05 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/14 10:23:05 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccEC2VPNConnectionDataSource_noInput (1.62s) --- PASS: TestAccEC2VPNConnectionDataSource_nonExistentId (2.57s) --- PASS: TestAccEC2VPNConnectionDataSource_byFilter (252.11s) --- PASS: TestAccEC2VPNConnectionDataSource_basic (252.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 259.363s ```

```console % make t K=ec2 T=TestAccVPNConnectionDataSource_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-aws_ec2_vpn_connection-new-data-source 🌿... TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPNConnectionDataSource_' -timeout 360m -vet=off 2025/10/15 16:51:14 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/15 16:51:14 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccVPNConnectionDataSource_noInput (1.42s) --- PASS: TestAccVPNConnectionDataSource_nonExistentId (2.32s) --- PASS: TestAccVPNConnectionDataSource_byFilter (243.04s) --- PASS: TestAccVPNConnectionDataSource_basic (243.18s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 250.058s ```

```console % make t K=ec2 T=TestAccVPNConnectionDataSource_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-aws_ec2_vpn_connection-new-data-source 🌿... TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPNConnectionDataSource_' -timeout 360m -vet=off 2025/10/15 17:01:59 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/15 17:01:59 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccVPNConnectionDataSource_noInput (1.61s) --- PASS: TestAccVPNConnectionDataSource_nonExistentId (2.56s) --- PASS: TestAccVPNConnectionDataSource_byFilter (298.01s) --- PASS: TestAccVPNConnectionDataSource_basic (588.72s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 595.637s ```

jar-b

LGTM 🚀

% make t K=ec2 T=TestAccVPNConnectionDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_ec2_vpn_connection-new-data-source 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPNConnectionDataSource_'  -timeout 360m -vet=off
2025/10/15 17:01:59 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/15 17:01:59 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccVPNConnectionDataSource_noInput (1.61s)
--- PASS: TestAccVPNConnectionDataSource_nonExistentId (2.56s)
--- PASS: TestAccVPNConnectionDataSource_byFilter (298.01s)
--- PASS: TestAccVPNConnectionDataSource_basic (588.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        595.637s

johnsonaj

LGTM 🚀

github-actions · 2025-10-15T22:40:49Z

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions · 2025-10-16T20:05:26Z

This functionality has been released in v6.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

subham-ibmhc added the rnd-ind-provider rnd-ind-provider label Oct 11, 2025

subham-ibmhc added 2 commits October 13, 2025 20:22

fix failing checks

14e90e9

fix linting

cc8ee5a

jar-b reviewed Oct 13, 2025

View reviewed changes

subham-ibmhc and others added 5 commits October 14, 2025 03:12

use autoflex, improve tests, fix documentation

43913e1

add changelog file

3edc569

fixed testnames, filenames

6690fd5

pull changes

b21512f

github-actions bot added the service/vpnsite Issues and PRs that pertain to the vpnsite service. label Oct 14, 2025

subham-ibmhc changed the title ~~[New Data Source]: aws_ec2_vpn_connection: Add new data source to fetch information about an EC2 VPN Connection.~~ [New Data Source]: aws_vpn_connection: Add new data source to fetch information about an EC2 VPN Connection. Oct 14, 2025

subham-ibmhc marked this pull request as ready for review October 14, 2025 20:56

subham-ibmhc requested a review from a team as a code owner October 14, 2025 20:56

jar-b added 3 commits October 15, 2025 15:54

d/vpn_connection: match file naming with resource

b5e010e

jar-b previously approved these changes Oct 15, 2025

View reviewed changes

chore: fix semgrep findings

db3ac2f

jar-b dismissed their stale review via db3ac2f October 15, 2025 21:17

johnsonaj approved these changes Oct 15, 2025

View reviewed changes

subham-ibmhc merged commit d0a5e9c into hashicorp:main Oct 15, 2025
43 checks passed

github-actions bot added this to the v6.17.0 milestone Oct 15, 2025

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[New Data Source]: aws_vpn_connection: Add new data source to fetch information about an EC2 VPN Connection. #44622

[New Data Source]: aws_vpn_connection: Add new data source to fetch information about an EC2 VPN Connection. #44622

Uh oh!

subham-ibmhc commented Oct 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jar-b left a comment

Uh oh!

johnsonaj left a comment

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[New Data Source]: aws_vpn_connection: Add new data source to fetch information about an EC2 VPN Connection. #44622

[New Data Source]: aws_vpn_connection: Add new data source to fetch information about an EC2 VPN Connection. #44622

Uh oh!

Conversation

subham-ibmhc commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rollback Plan

Changes to Security Controls

Description

Relations

References

Output from Acceptance Testing

Uh oh!

github-actions bot commented Oct 10, 2025

Community Guidelines

Voting for Prioritization

Pull Request Authors

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jar-b left a comment

Choose a reason for hiding this comment

Uh oh!

johnsonaj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

subham-ibmhc commented Oct 10, 2025 •

edited

Loading