Skip to content

Conversation

Shiva-Sai-ssb
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • Removed the extra KMS key policy note to simplify documentation.

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@Shiva-Sai-ssb Shiva-Sai-ssb requested a review from a team as a code owner October 13, 2025 14:48
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR. labels Oct 13, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Oct 14, 2025
@jar-b
Copy link
Member

jar-b commented Oct 14, 2025

Thank you for the correction, @Shiva-Sai-ssb! 👍

@Shiva-Sai-ssb
Copy link
Contributor Author

Hey @jar-b, sorry for the ping. Any reason this PR isn’t merged yet?

@jar-b
Copy link
Member

jar-b commented Oct 17, 2025

Apologies, lost track of this while waiting on CI to run.

@jar-b jar-b merged commit ca7cf8f into hashicorp:main Oct 17, 2025
25 checks passed
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.18.0 milestone Oct 17, 2025
@Shiva-Sai-ssb Shiva-Sai-ssb deleted the d-remove-extra-note branch October 17, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants