Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .ci/.semgrep-service-name0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4451,3 +4451,31 @@ rules:
- pattern-not-regex: "^TestAccConfigService"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: configservice-in-const-name
languages:
- go
message: Do not use "ConfigService" in const name inside configservice package
paths:
include:
- "/internal/service/configservice"
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)ConfigService"
severity: WARNING
- id: configservice-in-var-name
languages:
- go
message: Do not use "ConfigService" in var name inside configservice package
paths:
include:
- "/internal/service/configservice"
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)ConfigService"
severity: WARNING
86 changes: 58 additions & 28 deletions .ci/.semgrep-service-name1.yml
Original file line number Diff line number Diff line change
@@ -1,33 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: configservice-in-const-name
languages:
- go
message: Do not use "ConfigService" in const name inside configservice package
paths:
include:
- "/internal/service/configservice"
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)ConfigService"
severity: WARNING
- id: configservice-in-var-name
languages:
- go
message: Do not use "ConfigService" in var name inside configservice package
paths:
include:
- "/internal/service/configservice"
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)ConfigService"
severity: WARNING
- id: connect-in-func-name
languages:
- go
Expand Down Expand Up @@ -4445,3 +4417,61 @@ rules:
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: iot-in-test-name
languages:
- go
message: Include "IoT" in test name
paths:
include:
- "/internal/service/iot/*_test.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIoT"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: iot-in-const-name
languages:
- go
message: Do not use "IoT" in const name inside iot package
paths:
include:
- "/internal/service/iot"
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
severity: WARNING
- id: iot-in-var-name
languages:
- go
message: Do not use "IoT" in var name inside iot package
paths:
include:
- "/internal/service/iot"
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
severity: WARNING
- id: ipam-in-test-name
languages:
- go
message: Include "IPAM" in test name
paths:
include:
- "/internal/service/ec2/ipam_*_test.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIPAM"
- pattern-regex: ^TestAcc.*
severity: WARNING
161 changes: 91 additions & 70 deletions .ci/.semgrep-service-name2.yml
Original file line number Diff line number Diff line change
@@ -1,63 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: iot-in-test-name
languages:
- go
message: Include "IoT" in test name
paths:
include:
- "/internal/service/iot/*_test.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIoT"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: iot-in-const-name
languages:
- go
message: Do not use "IoT" in const name inside iot package
paths:
include:
- "/internal/service/iot"
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
severity: WARNING
- id: iot-in-var-name
languages:
- go
message: Do not use "IoT" in var name inside iot package
paths:
include:
- "/internal/service/iot"
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
severity: WARNING
- id: ipam-in-test-name
languages:
- go
message: Include "IPAM" in test name
paths:
include:
- "/internal/service/ec2/ipam_*_test.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIPAM"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: ivs-in-func-name
languages:
- go
Expand Down Expand Up @@ -4413,49 +4355,128 @@ rules:
patterns:
- pattern-regex: "(?i)RDS"
severity: WARNING
- id: recyclebin-in-func-name
- id: rdsdata-in-func-name
languages:
- go
message: Do not use "recyclebin" in func name inside rbin package
message: Do not use "RDSData" in func name inside rdsdata package
paths:
include:
- "/internal/service/rbin"
- "/internal/service/rdsdata"
exclude:
- "/internal/service/rbin/list_pages_gen.go"
- "/internal/service/rdsdata/list_pages_gen.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)recyclebin"
- pattern-regex: "(?i)RDSData"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: recyclebin-in-const-name
- id: rdsdata-in-test-name
languages:
- go
message: Do not use "recyclebin" in const name inside rbin package
message: Include "RDSData" in test name
paths:
include:
- "/internal/service/rbin"
- "/internal/service/rdsdata/*_test.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccRDSData"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: rdsdata-in-const-name
languages:
- go
message: Do not use "RDSData" in const name inside rdsdata package
paths:
include:
- "/internal/service/rdsdata"
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)recyclebin"
- pattern-regex: "(?i)RDSData"
severity: WARNING
- id: recyclebin-in-var-name
- id: rdsdata-in-var-name
languages:
- go
message: Do not use "recyclebin" in var name inside rbin package
message: Do not use "RDSData" in var name inside rdsdata package
paths:
include:
- "/internal/service/rbin"
- "/internal/service/rdsdata"
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RDSData"
severity: WARNING
- id: rdsdataservice-in-func-name
languages:
- go
message: Do not use "rdsdataservice" in func name inside rdsdata package
paths:
include:
- "/internal/service/rdsdata"
exclude:
- "/internal/service/rdsdata/list_pages_gen.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)rdsdataservice"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: rdsdataservice-in-const-name
languages:
- go
message: Do not use "rdsdataservice" in const name inside rdsdata package
paths:
include:
- "/internal/service/rdsdata"
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)rdsdataservice"
severity: WARNING
- id: rdsdataservice-in-var-name
languages:
- go
message: Do not use "rdsdataservice" in var name inside rdsdata package
paths:
include:
- "/internal/service/rdsdata"
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)rdsdataservice"
severity: WARNING
- id: recyclebin-in-func-name
languages:
- go
message: Do not use "recyclebin" in func name inside rbin package
paths:
include:
- "/internal/service/rbin"
exclude:
- "/internal/service/rbin/list_pages_gen.go"
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)recyclebin"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
28 changes: 28 additions & 0 deletions .ci/.semgrep-service-name3.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,33 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: recyclebin-in-const-name
languages:
- go
message: Do not use "recyclebin" in const name inside rbin package
paths:
include:
- "/internal/service/rbin"
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)recyclebin"
severity: WARNING
- id: recyclebin-in-var-name
languages:
- go
message: Do not use "recyclebin" in var name inside rbin package
paths:
include:
- "/internal/service/rbin"
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)recyclebin"
severity: WARNING
- id: redshift-in-func-name
languages:
- go
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services_all.kt
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ val services = mapOf(
"ram" to ServiceSpec("RAM (Resource Access Manager)"),
"rbin" to ServiceSpec("Recycle Bin (RBin)"),
"rds" to ServiceSpec("RDS (Relational Database)", vpcLock = true),
"rdsdata" to ServiceSpec("RDS Data"),
"redshift" to ServiceSpec("Redshift", vpcLock = true),
"redshiftdata" to ServiceSpec("Redshift Data"),
"redshiftserverless" to ServiceSpec("Redshift Serverless"),
Expand Down
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/ram v1.34.6
github.com/aws/aws-sdk-go-v2/service/rbin v1.26.6
github.com/aws/aws-sdk-go-v2/service/rds v1.108.1
github.com/aws/aws-sdk-go-v2/service/rdsdata v1.32.6
github.com/aws/aws-sdk-go-v2/service/redshift v1.59.0
github.com/aws/aws-sdk-go-v2/service/redshiftdata v1.37.6
github.com/aws/aws-sdk-go-v2/service/redshiftserverless v1.31.8
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,8 @@ github.com/aws/aws-sdk-go-v2/service/rbin v1.26.6 h1:wKVcl95mVcHW1rJMsf5SsA9T2zr
github.com/aws/aws-sdk-go-v2/service/rbin v1.26.6/go.mod h1:LCbTwbuAosB0UYOB4eMr7CmzwKPaO5ZD+UXEhJ6TPn4=
github.com/aws/aws-sdk-go-v2/service/rds v1.108.1 h1:Felh4W55+rsAjcg+EsRUdCWxXXyy3N9UJz4Ej5tLCC4=
github.com/aws/aws-sdk-go-v2/service/rds v1.108.1/go.mod h1:VOBL5tbhS7AF0m5YpfwLuRBpb5QVp4EWSPizUr/D6iE=
github.com/aws/aws-sdk-go-v2/service/rdsdata v1.32.6 h1:3E/6Am67lTTCpSS3f0cxT4IDW4THvXArhfvEIhQJGmM=
github.com/aws/aws-sdk-go-v2/service/rdsdata v1.32.6/go.mod h1:ZodWJ7ybwqVRgzlhnO0I86ZUu9S/2QBsMLfHyOCDVoU=
github.com/aws/aws-sdk-go-v2/service/redshift v1.59.0 h1:MtE4oUVeljvF2CWPZwzWERizY5uhZV7os1eJC9oA8BI=
github.com/aws/aws-sdk-go-v2/service/redshift v1.59.0/go.mod h1:ARgrCFhclWArEevJ/GAn+UBBVc9+f9oFurQlyjx262I=
github.com/aws/aws-sdk-go-v2/service/redshiftdata v1.37.6 h1:PC5iIPcOwMMqAocH4fuiyLKbEOKr9t75zhp7yysK0NY=
Expand Down
Loading
Loading