Skip to content

Conversation

@slqa
Copy link

@slqa slqa commented Jun 28, 2025

Fixes after this issue #12180 PR 13760

Due to non case sensitive powershell "memory" variable is evaluated as int due to "Memory" function parameter, and this causes an exception

Due to non case sensitive powershell "memory" is evaluated as int due to "Memory" function parameter, and thus an exception
@slqa slqa requested a review from a team as a code owner June 28, 2025 21:06
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Jun 28, 2025

CLA assistant check
All committers have signed the CLA.

@anshulsharma-hashicorp
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@slqa you need to sign CLA

@slqa
Copy link
Author

slqa commented Jun 30, 2025

@anshulsharma-hashicorp I thought I did it, on CLA page I click "Sign in with Github to agree", and then I'm landing on main CLA page, and there is nothing to do

edit. somehow other page appeared. done

@taru-garg-hashicorp
Copy link
Contributor

Hi @slqa,

Thanks a lot for your contribution! We received a similar PR #13691 fixing the same issue, a short while after this PR, which we decided to merge instead, as it also introduced some additional memory/CPU validation checks, which we felt are quite useful and necessary.

Apologies for the trouble, thanks again for your contribution!

@slqa slqa closed this Jul 21, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants