Remove up version limit of template-haskell and hashable #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I agree, personally. But I guess the policy of the maintainers is to have upper bounds strictly compatible with the PVP. |
|
I think this PR should be closed now that the respective bounds have been bumped: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, why upper versions of some dependencies are limited? Limiting upper version of packages causes dependency hell. The only reason why
masterdoes not compile withhashable 1.5.0.0andtemplate-haskell 2.22.0.0is upper limits for its versions. In my opinion, It would be better to limit upper version of libraries only when they change API in incompatible way.If API of any dependency will change in incompatible way,
unordered-containerswill not compile anyway. If next versions of dependencies would not break API (that is most often scenario),unordered-containerswill have compatibility for free, without updating upstream from<22to<23etc with every new dependency release.