Support Cabal-3.16 #1419
Support Cabal-3.16 #1419
Conversation
| putCopy JHC = contain $ putWord8 7 | ||
| putCopy LHC = contain $ putWord8 8 | ||
| putCopy UHC = contain $ putWord8 9 | ||
| #if !MIN_VERSION_Cabal_syntax(3,16,0) |
There was a problem hiding this comment.
Wouldn't it make sense to drop support for HaskellSuite as well?
There was a problem hiding this comment.
Dunno, this is just a minimal patch to get Hackage Server building.
There was a problem hiding this comment.
There is no mention of HaskellSuite removal in https://github.com/haskell/cabal/blob/master/release-notes/Cabal-3.16.0.0.md. Is that a mistake in code or changelog?
There was a problem hiding this comment.
Note: the safe-copy instances are part of acid-state persistence. Hopefully this won't cause problems with migration, but it could (it's not the same as adding constructor, like with MHS few releases back).
There was a problem hiding this comment.
There is no mention of HaskellSuite removal in https://github.com/haskell/cabal/blob/master/release-notes/Cabal-3.16.0.0.md. Is that a mistake in code or changelog?
I see:
Remove knowledge about hmake and haskell-suite haskell/cabal#10912
There was a problem hiding this comment.
@ulysses4ever that's a breaking change in library API. It's significant change.
There was a problem hiding this comment.
Fair point, thank you! Will try to adjust the process so that we get all API changes marked as significant.
There was a problem hiding this comment.
Also, removing HaskellSuite constructor was completely unnecessary, AFAICT.
There is e.g. Helium and being in this (pseudo)enum is the only reference of it.
There was a problem hiding this comment.
Also, removing
HaskellSuiteconstructor was completely unnecessary, AFAICT.
Yeah, maybe.
There is e.g.
Heliumand being in this (pseudo)enum is the only reference of it.
At least Helium once existed, in contrast to HaskellSuite: https://hackage.haskell.org/package/helium
|
@Bodigrim Can this be merged? GHC 9.14 alpha is out now. |
|
@andreasabel this is ready to be merged from my perspective, feel free to. |
No description provided.