Optimization test which use allocation #548
Merged
+166
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And sure enough it found problems with optimizations in older GHC |
Shimuuar
force-pushed
the
test-traverse-optimizations
branch
from
2621bd1 to
d7d4405
Compare
Co-authored-by: Alexey Kuleshevich <[email protected]>
This is good way to check that GHC generate tight non-allocating loops for monadic/applicative functions.
Shimuuar
force-pushed
the
test-traverse-optimizations
branch
2 times, most recently
from
9c5cf65 to
fea5c2d
Compare
Shimuuar
force-pushed
the
test-traverse-optimizations
branch
from
fea5c2d to
fc83758
Compare
|
I disabled some tests for older GHC (<9.4). I have no desire to find what went wrong with them. It will make nice regression test for GHC optimizer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach is complementary to inspection tests. We want to compile some functions on vectors to tight non allocating loops and it's difficult to formulate property in terms of inspection tests. It's however easy to measure allocation and check that we don't allocate anything except vector's buffer and some constant overhead
These test trip up if rewrite rules for
unstreamMandgenerateAare removed. So this is good way to check that rewrite rules and other optimizations work as intended and make much less scary to touch them.