-
Notifications
You must be signed in to change notification settings - Fork 51
Partially automate release - tagging and documentation generation [DI-669] #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Partially automate release - tagging and documentation generation [DI-669] #1362
Conversation
_Partially_ automates the steps in https://hazelcast.atlassian.net/wiki/spaces/HZC/pages/129810774/C+Client+Release+Process Specifically: - Git tagging - Doxygen By scripting and chaining the steps, the (manual) release work is reduced and consistency is improved. Tagging logic based on [approach in `hazelcast-docker`](https://github.com/hazelcast/hazelcast-docker/blob/master/.github/workflows/retag.yml). Of note - the instructions call for an "annotated tag" (`tag -a`). While this [seems more sensible](https://stackoverflow.com/q/4971746), it's not [how we make tags elsewhere](https://github.com/search?q=org%3Ahazelcast%20%22git%20tag%22&type=code) (most notablly - [in the release pipeline](https://github.com/hazelcast/hazelcast-pipeline-library/blob/43882a84b3715e2ac74f84c92f3c3d170504f2ab/src/com/hazelcast/qe/pipeline/git/Branch.groovy#L122-L127)), so for consistency I've changed to lightweight tags. Testing: - [example execution](https://github.com/JackPGreen/hazelcast-cpp-client/actions/runs/19150806835) - [tag created](https://github.com/JackPGreen/hazelcast-cpp-client/releases/tag/v5.5.3) - [documentation PR raised](#4) Post-merge actions: - [ ] update docs
|
@JackPGreen |
🧙 |
ihsandemir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way you can test this workflow?
|
|
||
| # doc-index.html | ||
| sed -i \ | ||
| "/Development Branch/a\<li><a href=\"https://github.com/${GITHUB_REPOSITORY}/blob/${{ needs.prepare.outputs.tag_name }}/Reference_Manual.md\">${{ inputs.BRANCH_NAME }}</a></li>" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this cause the development branch disappear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this cause the development branch disappear?
No - it's simply using Development Branch as an anchor to insert the content below (assuming it goes at the top of the list, enough for now).
For validation - check the diff in the doc PR it generated.
Partially automates the steps listed in the
C++ Client Release Processdocumentation.Specifically, steps:
Git taggingDoxygenBy scripting and chaining the steps, the (manual) release work is reduced and consistency is improved. Tagging logic based on approach in
hazelcast-docker.Where possible, I've tried to replicate how it currently works. It's likely there's future scope to improve (e.g. should the documentation updates really raise a PR?).
Of note - the instructions call for an "annotated tag" (
tag -a). While this seems more sensible, it's not how we make tags elsewhere (most notably - in the release pipeline), so for consistency I've changed to lightweight tags.Testing (in my fork):
Post-merge actions:
Partially addresses: DI-669