Skip to content

Conversation

@kristina-fefelova
Copy link
Member

No description provided.

@kristina-fefelova kristina-fefelova requested a review from Copilot May 27, 2025 21:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances activity tracking by emitting messages for collaborator additions/removals and card type changes, standardizes event metadata with creator/created fields, and updates middleware and database adapters to support these fields.

  • Add activity message triggers for collaborator updates and card type changes.
  • Extend request/response event schemas and middleware to include creator and created metadata.
  • Implement getNameByAccount in the CockroachDB adapter and name‐formatting utilities.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/server/src/triggers/notification.ts Add activity messages for collaborator additions/removals
packages/server/src/triggers/card.ts New trigger for card type change activities
packages/server/src/triggers/message.ts Skip collaborator logic for activity messages
packages/server/src/middlewares.ts Initialize accountBySocialID context
packages/server/src/middleware/validate.ts Update schemas to use creator/created fields
packages/server/src/middleware/triggers.ts Pass new context field to triggers middleware
packages/server/src/middleware/permissions.ts Permit new request event types
packages/server/src/middleware/db.ts Persist creator/created for collaborator and card updates
packages/server/src/middleware/date.ts Populate created for new event types
packages/sdk-types/src/... Extend request/response types with creator/created
packages/query/src/messages/query.ts Remove empty‐content filter in message query
packages/cockroach/src/utils.ts Add name‐formatting helpers
packages/cockroach/src/adapter.ts Implement getNameByAccount in DB adapter
package.json Bump typescript-eslint version
.version Increment package version
Comments suppressed due to low confidence (3)

packages/query/src/messages/query.ts:812

  • Removing this empty-content filter allows blank messages to be processed and stored; verify if this was intentional, as it may lead to unexpected empty entries.
if (message.content.trim() === '') return

packages/server/src/triggers/notification.ts:60

  • [nitpick] The variable name updateDate is misleading—it holds collaborators update data, not a date. Consider renaming to updateData or collaboratorsUpdate.
const updateDate: ActivityCollaboratorsUpdate = {

packages/server/src/triggers/message.ts:157

  • MessageType is not imported in this module, causing a ReferenceError; add import { MessageType } from '@hcengineering/communication-types'.
if (type === MessageType.Activity) return []

@kristina-fefelova kristina-fefelova merged commit 29458d3 into main May 27, 2025
1 check passed
@kristina-fefelova kristina-fefelova deleted the more-activity branch May 27, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants