feat(android): Add custom font-family support for Android #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds custom font-family prop support for the Android version of the React Native Date Picker library. The implementation improves styling flexibility by allowing developers to specify custom fonts for the picker's UI elements, without introducing any breaking changes.
All changes are isolated to the Android implementation and were made with reliability, backward compatibility, and clarity in mind.
✨ Highlights
Adds support for a font-family prop (Android-only)
Implements safe font loading with fallbacks and error logging
Improves reflection handling to reduce crash risk
Updates documentation with clear usage guidance
🔧 Technical Breakdown
Files: FontFamily.java, DatePickerModuleImpl.java
Added try-catch blocks with fallback to default font when loading fails
Log errors to assist in debugging
Ensures app doesn’t crash due to misconfigured or missing fonts
File: FontFamily.java
Wrapped reflection code with error handling
Skips applying fonts if expected fields or views aren’t found
Prevents runtime exceptions across different Android versions
Files: FontFamily.java, README.md
Added JavaDoc comments explaining the new logic
Updated README.md with usage instructions for the new prop
✅ Verification
All changes tested on Android devices/emulators
Validated against edge cases (missing fonts, invalid input, etc.)
Confirmed no breaking behavior on devices without the font-family prop
📝 Usage Example
<DatePicker
mode="date"
value={new Date()}
onChange={handleChange}
fontFamily="CustomFont-Regular" // Font file placed in android/app/src/main/assets/fonts/
/>
📂 Assets
Ensure your custom font file is located at:
android/app/src/main/assets/fonts/CustomFont-Regular.ttf
🧠 Rationale
This feature was implemented after reviewing internal customization needs and frequent community requests for improved styling support. All logic was built to be safe, fallback-friendly, and easy to extend in the future.
🙌 Final Notes
This PR is ready for review. I’d be happy to make adjustments based on your feedback.
Thanks for maintaining this great library!