Skip to content

Conversation

diachenko-mischa
Copy link
Contributor

@diachenko-mischa diachenko-mischa commented Oct 10, 2025

Adds interface for the method to list keys available in the cache.

Allows client software to not maintain the journal or another metadata to
maintain a list of entries available in the database. Moreover, having
an explicit journal is still not reliable as API does not provide an interface
for maintaining transactions in order to have an atomic insert + journal update.

This API will help to implement reliable uploading strategy: in case of
upload failure payload will be stored on the disk and retried later.

In order to query payloads effectively, software needs to access the
list of available keys.

Relates-To: HERESDK-8383

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.31%. Comparing base (e2da4d1) to head (2db0b66).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
+ Coverage   80.26%   80.31%   +0.04%     
==========================================
  Files         349      349              
  Lines       13953    13953              
  Branches     1493     1493              
==========================================
+ Hits        11199    11205       +6     
+ Misses       2153     2149       -4     
+ Partials      601      599       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Adds interface for the method to list keys available in the cache.

Relates-To: HERESDK-8383
Signed-off-by: Mykhailo Diachenko <[email protected]>
@diachenko-mischa diachenko-mischa force-pushed the mdiachenko/HERESDK-8383-AddMethodToListKeys branch from 99df81f to 2db0b66 Compare October 10, 2025 11:09
@mykolamalik
Copy link
Contributor

@diachenko-mischa
Please extend the MR description with the reasoning on why such an interface is needed. The description of the HERESDK-8383 ticket doesn't contain this information.

@diachenko-mischa
Copy link
Contributor Author

Updated MR description.

@diachenko-mischa diachenko-mischa merged commit 65757ff into master Oct 13, 2025
25 checks passed
@diachenko-mischa diachenko-mischa deleted the mdiachenko/HERESDK-8383-AddMethodToListKeys branch October 13, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants