Fix MSI Claw Device Issues #217
Conversation
Shouldn't closing the fd descriptor automatically do that? |
| d_kbd_2.dev.grab() | ||
| d_kbd_2_grabbed = True | ||
| except Exception: | ||
| pass # Ignore grab failures, continue without grabbing |
There was a problem hiding this comment.
Why would there be a grab failure?
There was a problem hiding this comment.
Just referenced Ally's implementation.
| # If no specific devices to reload but we removed rules, reload all input devices | ||
| if removed and not _hidden: | ||
| subprocess.run(["udevadm", "trigger", "--subsystem-match=input"], capture_output=True) | ||
| subprocess.run(["udevadm", "settle"], capture_output=True) |
There was a problem hiding this comment.
waits for all events to finish
| "MSI Claw A8", | ||
| "Claw A8 BZ2EM", | ||
| type="only_press", | ||
| phys=["gpio-keys", "LNXPWRBN", "PNP0C0C"], |
There was a problem hiding this comment.
does grabbing gpio-keys break the volume buttons?
There was a problem hiding this comment.
does grabbing gpio-keys break the volume buttons?
will not
But according to my tests, without adding it, the MSI Xbox device cannot ungrab properly. Perhaps I haven't found the right reason ？ |
If not it means the device wasnt closed properly and there is a descriptor leak. Perhaps during init. Otherwise, there is a chance the overlay has temporarily grabbed it because it is open. |
Then I probably haven't found the root cause. |
Fix unhide_all() to trigger udev reload even when _hidden list is empty. Resolves devices remaining with 000 permissions after HHD stops.
2 participants
Fix MSI Claw Device Issues
Problem
Solution
ungrab()inGenericGamepadEvdev.close()to prevent resource leaksunhide_all()to trigger udev reload even when device tracking list is emptygpio-keysidentifier for MSI Claw A8 power buttonResolves critical usability issues for MSI Claw users including XInput mode startup and proper device cleanup.