Terrible error reporting when JDBC scheme is not recognized #2478 #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the solution is causing issues with Microsoft SQL Server , working on a different solution |
dreab8
force-pushed
the
issue_2478
branch
3 times, most recently
from
7d4fe59 to
ee8e2ef
Compare
DavideD
reviewed
Sep 23, 2025
...e-core/src/main/java/org/hibernate/reactive/pool/impl/DefaultSqlClientPoolConfiguration.java
Outdated
Show resolved
Hide resolved
...e-core/src/main/java/org/hibernate/reactive/pool/impl/DefaultSqlClientPoolConfiguration.java
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/WrongJdbcUrlShemeTest.java
Outdated
Show resolved
Hide resolved
...e-core/src/main/java/org/hibernate/reactive/provider/service/NoJdbcEnvironmentInitiator.java
Outdated
Show resolved
Hide resolved
DavideD
reviewed
Sep 24, 2025
| @Message(id = 48, value = "Could not determine Dialect from JDBC driver metadata (specify a connection URI with scheme 'postgresql:', 'mysql:', 'cockroachdb', or 'db2:')") | ||
| HibernateException couldNotDetermineDialectFromJdbcDriverMetadata(); | ||
|
|
||
| @Message(id = 49, value = "Could not determine Dialect from connection URI: '%1$s' (specify a connection URI with scheme 'postgresql:', 'mysql:', 'cockroachdb', or 'db2:')") |
There was a problem hiding this comment.
I think that the list of supported schemas in the error message is missing postgres:, oracle:, sqlserver:, and mariadb:
DavideD
reviewed
Sep 24, 2025
|
|
||
| private static void assertException(Throwable throwable) { | ||
| assertThat( throwable.getMessage() ) | ||
| .contains( "HR000049" ); |
There was a problem hiding this comment.
Could you change this to
assertThat( throwable ).hasMessageContaining( "HR000049" );please?
It will give us extra information about the exception thrown if something is wrong with the message
DavideD
reviewed
Sep 24, 2025
| HibernateException couldNotDetermineDialectFromJdbcDriverMetadata(); | ||
|
|
||
| @Message(id = 49, value = "Could not determine Dialect from connection URI: '%1$s' (specify a connection URI with scheme 'postgresql:', 'mysql:', 'cockroachdb', or 'db2:')") | ||
| HibernateException couldNotDetermineDialectFromConnectionURI(String url); |
There was a problem hiding this comment.
JdbcUrlParserTest expects an IllegalArgumentException and not an HibernateException.
I think it makes sense to return an IllegalArgumentException here.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2478