Skip to content

HSEARCH-5441 Explicitly add mockito agent to the surefire args #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HSEARCH-5441 Explicitly add mockito agent to the surefire args #4743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions build/parents/build/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,6 +1404,17 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>properties</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
Expand Down
9 changes: 6 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,15 @@
<!-- Set empty default values to avoid Maven leaving property references (${...}) when it doesn't find a value -->

<surefire.jvm.args.memory>-Xmx512m -Xms128m</surefire.jvm.args.memory>
<surefire.jvm.args.misc>-Djdk.attach.allowAttachSelf=true</surefire.jvm.args.misc>
<surefire.jvm.args.misc></surefire.jvm.args.misc>
<!-- JVM args to be customized depending on the Java version -->
<surefire.jvm.args.java-version></surefire.jvm.args.java-version>
<!-- JVM args generated by JaCoCo -->
<surefire.jvm.args.jacoco></surefire.jvm.args.jacoco>
<failsafe.jvm.args.jacoco></failsafe.jvm.args.jacoco>
<!-- JVM args to attach agents e.g. for Mockito -->
<surefire.jvm.args.agents>-javaagent:${org.mockito:mockito-core:jar}</surefire.jvm.args.agents>

<!-- JVM args to be customized by each Maven module -->
<surefire.jvm.args.module></surefire.jvm.args.module>
<surefire.jvm.args.module.add-opens></surefire.jvm.args.module.add-opens>
Expand All @@ -426,8 +429,8 @@
http://maven.apache.org/surefire/maven-surefire-plugin/faq.html#late-property-evaluation
This is necessary for Jacoco to work as expected.
-->
<surefire.jvm.args.no-jacoco>${surefire.jvm.args.memory} ${surefire.jvm.args.misc} ${surefire.jvm.args.java-version} ${surefire.jvm.args.module} ${test.launcher.args}</surefire.jvm.args.no-jacoco>
<failsafe.jvm.args.no-jacoco>${surefire.jvm.args.memory} ${surefire.jvm.args.misc} ${surefire.jvm.args.java-version} ${surefire.jvm.args.module} ${test.launcher.args} ${failsafe.jvm.args.hibernate-orm} ${failsafe.jvm.args.jdbc}</failsafe.jvm.args.no-jacoco>
<surefire.jvm.args.no-jacoco>${surefire.jvm.args.memory} ${surefire.jvm.args.misc} ${surefire.jvm.args.java-version} ${surefire.jvm.args.module} ${test.launcher.args} ${surefire.jvm.args.agents}</surefire.jvm.args.no-jacoco>
<failsafe.jvm.args.no-jacoco>${surefire.jvm.args.memory} ${surefire.jvm.args.misc} ${surefire.jvm.args.java-version} ${surefire.jvm.args.module} ${test.launcher.args} ${surefire.jvm.args.agents} ${failsafe.jvm.args.hibernate-orm} ${failsafe.jvm.args.jdbc}</failsafe.jvm.args.no-jacoco>
<surefire.jvm.args>${surefire.jvm.args.no-jacoco} @{surefire.jvm.args.jacoco}</surefire.jvm.args>
<failsafe.jvm.args>${surefire.jvm.args.no-jacoco} @{failsafe.jvm.args.jacoco}</failsafe.jvm.args>

Expand Down
Loading