chore: 21078: StateLogger is no longer used and can be removed

[artemananiev]

Fix summary: StateLogger is removed, as well as all the state change loggins calls from State API.

Fixes: #21078
Signed-off-by: Artem Ananev [email protected]

[lfdt-bot]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.03% (target: -1.00%)	✅ 77.78%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (06a3c78)	103353	77681	75.16%
Head commit (d9ab8c0)	103324 (-29)	77627 (-54)	75.13% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#21156)	9	7	77.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[codecov]

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...irlds/state/merkle/disk/OnDiskReadableKVState.java	50.00%	1 Missing ⚠️
...ds/state/merkle/disk/OnDiskReadableQueueState.java	50.00%	0 Missing and 1 partial ⚠️
...tate/merkle/disk/OnDiskReadableSingletonState.java	0.00%	0 Missing and 1 partial ⚠️
...irlds/state/merkle/disk/OnDiskWritableKVState.java	50.00%	1 Missing ⚠️

@@             Coverage Diff              @@
##               main   #21156      +/-   ##
============================================
- Coverage     71.23%   71.21%   -0.02%     
+ Complexity    24259    24241      -18     
============================================
  Files          2661     2661              
  Lines        103448   103419      -29     
  Branches      10815    10815              
============================================
- Hits          73691    73651      -40     
- Misses        25723    25748      +25     
+ Partials       4034     4020      -14     

Files with missing lines	Coverage Δ	Complexity Δ
...ava/com/swirlds/state/spi/ReadableKVStateBase.java	100.00% <ø> (ø)	13.00 <0.00> (ø)
...ds/state/merkle/disk/OnDiskWritableQueueState.java	83.33% <100.00%> (ø)	5.00 <0.00> (ø)
...tate/merkle/disk/OnDiskWritableSingletonState.java	73.33% <100.00%> (-0.36%)	4.00 <0.00> (ø)
...irlds/state/merkle/disk/OnDiskReadableKVState.java	92.30% <50.00%> (+8.97%)	5.00 <0.00> (ø)
...ds/state/merkle/disk/OnDiskReadableQueueState.java	70.00% <50.00%> (-8.58%)	3.00 <0.00> (ø)
...tate/merkle/disk/OnDiskReadableSingletonState.java	85.71% <0.00%> (-3.18%)	2.00 <0.00> (ø)
...irlds/state/merkle/disk/OnDiskWritableKVState.java	90.00% <50.00%> (+4.81%)	8.00 <0.00> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Neeharika-Sompalli]

LGTM! Thanks @artemananiev

[thenswan]

I left many similar comments, as I went and double-checked each class (if there is a need in a label), but they are all about one change - remove label from State API completely, as it was used only in StateLogger.

[thenswan]

After the discussion, we decided to make further changes in a follow up PR, to keep this one scoped to the relevant issue

[tinker-michaelj]

LGTM, tyvm @artemananiev !

[andrewb1269]

Approve .github/workflows/support/citr/log4j2.xml