feat: Add fees for hook transactions #21157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
timfn-hg
reviewed
Sep 22, 2025
...ode/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/fee/SmartContractFeeBuilder.java
Show resolved
Hide resolved
timfn-hg
reviewed
Sep 22, 2025
...ode/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/fee/SmartContractFeeBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <[email protected]>
rbarker-dev
previously approved these changes
Sep 30, 2025
Signed-off-by: Neeharika-Sompalli <[email protected]>
tinker-michaelj
previously approved these changes
Oct 3, 2025
Contributor
tinker-michaelj
left a comment
tinker-michaelj
left a comment
There was a problem hiding this comment.
This all makes sense to me, tyvm @Neeharika-Sompalli !
Signed-off-by: Neeharika-Sompalli <[email protected]>
Neeharika-Sompalli
dismissed stale reviews from xin-hedera and tinker-michaelj
via
0662b44
Nana-EC
approved these changes
Oct 3, 2025
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
Seems good on first pass.
Left on clarifying suggestion
...e/hapi-fees/src/main/java/com/hedera/node/app/hapi/fees/usage/crypto/CryptoTransferMeta.java
Show resolved
Hide resolved
akdev
approved these changes
Oct 4, 2025
tinker-michaelj
approved these changes
Oct 5, 2025
Contributor
tinker-michaelj
left a comment
tinker-michaelj
left a comment
There was a problem hiding this comment.
LGTM, tyvm @Neeharika-Sompalli !
mhess-swl
reviewed
Oct 7, 2025
Comment on lines
+330
to
+337
| if (hasPreTxHook) { | ||
| gas = clampedAdd( | ||
| gas, aa.preTxAllowanceHookOrThrow().evmHookCallOrThrow().gasLimit()); | ||
| } | ||
| if (hasPrePostTxHook) { | ||
| gas = clampedAdd( | ||
| gas, aa.prePostTxAllowanceHookOrThrow().evmHookCallOrThrow().gasLimit()); | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't these both be gas += clamedAdd(...)? (Javadoc: Adds gas from pre-tx and pre+post allowance hooks on an account transfer)
mxtartaglia-sl
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Neeharika-Sompalli <[email protected]> Signed-off-by: Michael Tinker <[email protected]> Co-authored-by: Michael Tinker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21090
SBSfee component inCryptoCreate/CryptoUpdate/ContractCreate/CryptoTransferto set the constant fees for hooks. UsedTVfee component to add the constant fees forContractUpdate. The reason for choosing these parameters is because they are not currently used in the calculation of fees for the respective handlers.NOTE: All this calculation using the respective fee components will be changed very soon with Simple fees.
feeSchedules.jsonto reflect new fee data