Skip to content

Conversation

@netopyr
Copy link
Contributor

@netopyr netopyr commented Sep 25, 2025

Description:

This PR adds new log assertions that were introduced in the PoC and should be generally available. There are also some bug fixes included that popped up recently.

Related issue(s):

Fixes #21225

@netopyr netopyr added this to the v0.68 milestone Sep 25, 2025
@netopyr netopyr requested review from poulok and timo0 September 25, 2025 07:20
@netopyr netopyr self-assigned this Sep 25, 2025
@netopyr netopyr requested a review from a team as a code owner September 25, 2025 07:20
@lfdt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21233   +/-   ##
=========================================
  Coverage     71.23%   71.23%           
- Complexity    24199    24200    +1     
=========================================
  Files          2669     2669           
  Lines        103299   103299           
  Branches      10753    10753           
=========================================
+ Hits          73581    73582    +1     
  Misses        25679    25679           
+ Partials       4039     4038    -1     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (faf315c) 103204 77574 75.17%
Head commit (8fecbe3) 103204 (+0) 77574 (+0) 75.17% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21233) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@netopyr netopyr marked this pull request as draft September 25, 2025 08:17
@netopyr netopyr marked this pull request as ready for review September 25, 2025 10:42
@netopyr netopyr merged commit 5c8c3dc into main Sep 26, 2025
64 of 65 checks passed
@netopyr netopyr deleted the 21225-additional-log-assertions branch September 26, 2025 15:40
mxtartaglia-sl pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add logging assertions from PoC

4 participants