Skip to content

Conversation

@petreze
Copy link
Contributor

@petreze petreze commented Sep 25, 2025

Description:

Related issue(s):

Fixes #21214

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionManager.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionManagerTest.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionTest.java
@petreze petreze self-assigned this Sep 25, 2025
@petreze petreze requested review from a team as code owners September 25, 2025 15:07
@lfdt-bot
Copy link

lfdt-bot commented Sep 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

codacy-production bot commented Sep 25, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 87.69%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e0e3e7b) 103714 77752 74.97%
Head commit (943ca66) 103747 (+33) 77787 (+35) 74.98% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21240) 65 57 87.69%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...cks/impl/streaming/BlockNodeConnectionManager.java 82.60% 6 Missing and 2 partials ⚠️
...app/blocks/impl/streaming/BlockNodeConnection.java 89.47% 2 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21240      +/-   ##
============================================
+ Coverage     71.04%   71.05%   +0.01%     
- Complexity    24234    24239       +5     
============================================
  Files          2673     2673              
  Lines        103809   103842      +33     
  Branches      10803    10807       +4     
============================================
+ Hits          73750    73786      +36     
+ Misses        26011    26009       -2     
+ Partials       4048     4047       -1     
Files with missing lines Coverage Δ Complexity Δ
...ra/node/config/data/BlockNodeConnectionConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...com/hedera/node/config/data/BlockStreamConfig.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...app/blocks/impl/streaming/BlockNodeConnection.java 77.33% <89.47%> (-0.12%) 51.00 <2.00> (ø)
...cks/impl/streaming/BlockNodeConnectionManager.java 87.55% <82.60%> (+1.70%) 68.00 <2.00> (+3.00)

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petreze petreze merged commit 2f0d2c8 into main Sep 28, 2025
52 of 53 checks passed
@petreze petreze deleted the 21214-fix-exponential-backoff branch September 28, 2025 20:13
mxtartaglia-sl pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CN Needs an Exponential Backoff applied to BN in all failure cases

5 participants