-
Notifications
You must be signed in to change notification settings - Fork 184
feat: Simple Fees: use new extras for topic custom fees #22252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #22252 +/- ##
============================================
- Coverage 70.97% 70.94% -0.03%
+ Complexity 24616 24596 -20
============================================
Files 2698 2694 -4
Lines 104935 104913 -22
Branches 11029 11032 +3
============================================
- Hits 74478 74433 -45
- Misses 26441 26465 +24
+ Partials 4016 4015 -1
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
hedera-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/fees/CalculatorState.java
Outdated
Show resolved
Hide resolved
...com/hedera/node/app/service/consensus/impl/calculator/ConsensusCreateTopicFeeCalculator.java
Outdated
Show resolved
Hide resolved
...m/hedera/node/app/service/consensus/impl/calculator/ConsensusSubmitMessageFeeCalculator.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
delete old disabled tests expose readableStore() in CalculatorState Signed-off-by: Josh Marinacci <[email protected]>
address comments Signed-off-by: Josh Marinacci <[email protected]>
Signed-off-by: Josh Marinacci <[email protected]>
d6c70ec to
8746713
Compare
Signed-off-by: Josh Marinacci <[email protected]>
set fees for the custom fees extras Signed-off-by: Josh Marinacci <[email protected]>
Description:
To support custom fees properly we need custom extras in the Simple Fees fee schedule. This PR:
ConsensusCreateTopicFeeCalculatorandConsensusSubmitMessageFeeCalculatorto use these new extras.ConsensusServiceSimpleFeesSuite.It also exposes
readableStoreinCalculatorState.Related issue(s):
partially Fixes ##22171
Notes for reviewer:
Checklist