feat: Simple fees for Smart Contracts Service #22319
Conversation
Signed-off-by: ibankov <[email protected]>
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/FacilityInitModule.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java
Signed-off-by: ibankov <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22319 +/- ##
============================================
- Coverage 70.99% 70.96% -0.03%
- Complexity 24651 24690 +39
============================================
Files 2699 2708 +9
Lines 105153 105385 +232
Branches 11050 11084 +34
============================================
+ Hits 74655 74789 +134
- Misses 26474 26560 +86
- Partials 4024 4036 +12
... and 24 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Show resolved
Hide resolved
| "extras": [ | ||
| { | ||
| "name": "KEYS", | ||
| "includedCount": 1 |
There was a problem hiding this comment.
Shouldn't we also mention the default gas included? from here its 500k
There was a problem hiding this comment.
As discussed with Michael, I left the gas charging as it is and I'm not considering it as an extra.
There was a problem hiding this comment.
@Neeharika-Sompalli are you satisfied with this answer? If so I'll approve it.
| final long keys = adminKey != null ? countKeys(adminKey) : 0; | ||
| final ServiceFeeDefinition serviceDef = lookupServiceFee(feeSchedule, HederaFunctionality.CONTRACT_CREATE); | ||
| feeResult.addServiceFee(1, serviceDef.baseFee()); | ||
| addExtraFee(feeResult, serviceDef, KEYS, feeSchedule, keys); |
There was a problem hiding this comment.
Same here, This fee calculation says we havee included some gas. Should we account for that?
Description:
Simple fees implementation for Smart Contracts Service.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist